Improving gha's to make them consistent by kunal-511 · Pull Request #3099 · kubeflow/manifests

kunal-511 · 2025-04-15T18:36:39Z

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

Updated the gha to use istio-cni instead of istio.
Added model registry tests to the end to end workflow
Updated the titles of gha to make them consistent

🐛 Related Issues

#3054

✅ Contributor Checklist

I have tested these changes with kustomize. See Installation Prerequisites.
All commits are signed-off to satisfy the DCO check.

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

…and test part seperate Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

juliusvonkohout · 2025-04-16T06:54:51Z

/ok-to-test

.github/workflows/model_registry_test.yaml

.github/workflows/full_kubeflow_integration_test.yaml

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

.github/workflows/admission_webhook_test.yaml

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

…yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

juliusvonkohout · 2025-04-17T09:14:34Z

Thank you.
/lgtm
/approve

please fix the remaining names and items in a follow up PR.

google-oss-prow · 2025-04-17T09:14:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [juliusvonkohout]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Improving gha's to make them consistent Signed-off-by: kunal-511 <yoyokvunal@gmail.com> * Changed back the spark script file names Signed-off-by: kunal-511 <yoyokvunal@gmail.com> * fix the structure of the end to end integration to keep install part and test part seperate Signed-off-by: kunal-511 <yoyokvunal@gmail.com> * Fixed the pod timming issue Signed-off-by: kunal-511 <yoyokvunal@gmail.com> * Added unauthorized test for model registry Signed-off-by: kunal-511 <yoyokvunal@gmail.com> * corrected the message Signed-off-by: kunal-511 <yoyokvunal@gmail.com> * Updated the title of gha's as suggested Signed-off-by: kunal-511 <yoyokvunal@gmail.com> * Updated the titles of workflows as suggested Signed-off-by: kunal-511 <yoyokvunal@gmail.com> * Fixed the lint errors Signed-off-by: kunal-511 <yoyokvunal@gmail.com> * Update kserve_m2m_test.yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Delete .github/workflows/notebook_controller_test.yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Update spark_test.yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Update ray_test.yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Update pipeline_test.yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Update pipeline_swfs_test.yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Update pipeline_run_from_notebook.yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Update notebook_controller_m2m_test.yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Update model_registry_test.yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Update kserve_m2m_test.yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Rename notebook_controller_m2m_test.yaml to notebook_controller_test.yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Rename kserve_m2m_test.yaml to kserve_test.yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Update full_kubeflow_integration_test.yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Update pipeline_swfs_test.yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Update pipeline_swfs_test.yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: kunal-511 <yoyokvunal@gmail.com> Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> Co-authored-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

Improving gha's to make them consistent

321255f

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

google-oss-prow bot added do-not-merge/work-in-progress size/M labels Apr 15, 2025

google-oss-prow bot requested review from juliusvonkohout and kimwnasptd April 15, 2025 18:36

Changed back the spark script file names

3d81fc7

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

kunal-511 marked this pull request as ready for review April 16, 2025 06:23

google-oss-prow bot removed the do-not-merge/work-in-progress label Apr 16, 2025

kunal-511 added 2 commits April 16, 2025 11:58

fix the structure of the end to end integration to keep install part …

9055c06

…and test part seperate Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Fixed the pod timming issue

c27ef68

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

juliusvonkohout self-assigned this Apr 16, 2025

google-oss-prow bot added the ok-to-test label Apr 16, 2025

juliusvonkohout reviewed Apr 16, 2025

View reviewed changes

.github/workflows/model_registry_test.yaml Show resolved Hide resolved

juliusvonkohout reviewed Apr 16, 2025

View reviewed changes

.github/workflows/full_kubeflow_integration_test.yaml Show resolved Hide resolved

juliusvonkohout reviewed Apr 16, 2025

View reviewed changes

.github/workflows/full_kubeflow_integration_test.yaml Show resolved Hide resolved

kunal-511 added 3 commits April 16, 2025 13:27

Added unauthorized test for model registry

71de9e2

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

corrected the message

9ab0a2c

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Updated the title of gha's as suggested

df72738

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

google-oss-prow bot added size/L and removed size/M labels Apr 16, 2025

juliusvonkohout reviewed Apr 16, 2025

View reviewed changes

.github/workflows/admission_webhook_test.yaml Show resolved Hide resolved

kunal-511 and others added 8 commits April 17, 2025 10:41

Updated the titles of workflows as suggested

686c088

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Fixed the lint errors

c1a47fd

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Update kserve_m2m_test.yaml

fa1444e

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

Delete .github/workflows/notebook_controller_test.yaml

11276ec

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

Update spark_test.yaml

42a4195

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

Update ray_test.yaml

c4994d4

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

Update pipeline_test.yaml

835b02a

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

Update pipeline_swfs_test.yaml

cdfa0f9

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

juliusvonkohout added 9 commits April 17, 2025 09:18

Update pipeline_run_from_notebook.yaml

1f3c4e0

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

Update notebook_controller_m2m_test.yaml

c37d0a3

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

Update model_registry_test.yaml

8b613ae

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

Update kserve_m2m_test.yaml

80b2e6b

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

Rename notebook_controller_m2m_test.yaml to notebook_controller_test.…

4f94586

…yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

Rename kserve_m2m_test.yaml to kserve_test.yaml

272fa99

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

Update full_kubeflow_integration_test.yaml

4c39f4b

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

Update pipeline_swfs_test.yaml

9198a10

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

Update pipeline_swfs_test.yaml

76b709f

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

google-oss-prow bot added the lgtm label Apr 17, 2025

google-oss-prow bot added the approved label Apr 17, 2025

google-oss-prow bot merged commit d6a7fe9 into kubeflow:master Apr 17, 2025
24 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Improving gha's to make them consistent#3099

Improving gha's to make them consistent#3099
google-oss-prow[bot] merged 24 commits intokubeflow:masterfrom
kunal-511:making-gha-consistent

kunal-511 commented Apr 15, 2025 •

edited

Loading

Uh oh!

juliusvonkohout commented Apr 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juliusvonkohout commented Apr 17, 2025 •

edited

Loading

Uh oh!

google-oss-prow bot commented Apr 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

kunal-511 commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

🐛 Related Issues

✅ Contributor Checklist

Uh oh!

juliusvonkohout commented Apr 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juliusvonkohout commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-oss-prow bot commented Apr 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kunal-511 commented Apr 15, 2025 •

edited

Loading

juliusvonkohout commented Apr 17, 2025 •

edited

Loading