-
Notifications
You must be signed in to change notification settings - Fork 1k
fix: update README for user namespace installation using KF_PROFILE script #3316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
2729f1a to
44b5aa1
Compare
…cript Signed-off-by: Aniket Patil <[email protected]>
44b5aa1 to
de7514e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you create this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍
That file was added unintentionally and is not required.
I’ve removed it in the latest commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the original issue was only a bug of kustomize 5.8.0 instead of 5.7.1 but we should link our tests suite here https://github.com/kubeflow/manifests/blob/master/.github/workflows/full_kubeflow_integration_test.yaml at the beginning of the step by step install and tell people that this workflow is verified on each commit to master. and we can maybe switch all step by step commands to use our scripts that we also use in https://github.com/kubeflow/manifests/blob/master/.github/workflows/full_kubeflow_integration_test.yaml
|
Maybe you are also interested in #3313 |
Signed-off-by: Aniket Patil <[email protected]>
✏️ Summary of Changes
Updated the README to replace the direct
kustomizecommand for creating the user namespace with the recommended KF_PROFILE script approach:📦 Dependencies
No external dependencies.
🐛 Related Issues
Fixes #3315 - Kubeflow profile creation error in default KIND configuration.
✅ Contributor Checklist