-
Notifications
You must be signed in to change notification settings - Fork 1k
fix(knative): update PDBs to allow node drain #3317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(knative): update PDBs to allow node drain #3317
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hello, please make sure that you are on the latest master branch with the Knative 1.20 commit. please rebase your branch if not and never merge from master |
Signed-off-by: Aniket Patil <[email protected]>
999f749 to
68523a9
Compare
Rebased onto latest master (Knative 1.20) — PR is now up-to-date and ready for review. |
|
@juliusvonkohout @kimwnasptd I’ve updated the changes. Please review them |
|
/hold |
|
Maybe we can drop https://github.com/aniketpati1121/manifests/blob/fix-knative-pdb-single-replica/common/knative/knative-serving/base/patches/seccomp.yaml and https://github.com/aniketpati1121/manifests/blob/fix-knative-pdb-single-replica/common/knative/knative-serving/base/patches/sidecar-injection.yaml. in the end you can test it in this PR here. If all tests are green we are good. |
|
For knative-eventing https://github.com/aniketpati1121/manifests/blob/fix-knative-pdb-single-replica/common/knative/knative-eventing/base/kustomization.yaml I am also on vacation so please expect delays. |
✏️ Summary of Changes
minAvailableand replicas to allow safe node drain for single-replica deployments🐛 Related Issues
Fixes #3313