Skip to content

Conversation

@aniketpati1121
Copy link
Contributor

@aniketpati1121 aniketpati1121 commented Jan 4, 2026

✏️ Summary of Changes

  • Updated PodDisruptionBudgets (PDBs) for Knative core components (activator, webhook, eventing-webhook)
  • Adjusted minAvailable and replicas to allow safe node drain for single-replica deployments
  • Ensures cluster maintenance can proceed without manually evicting pods or blocking drains

🐛 Related Issues

Fixes #3313

WhatsApp Image 2026-01-04 at 16 39 46

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign juliusvonkohout for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Jan 5, 2026

Hello, please make sure that you are on the latest master branch with the Knative 1.20 commit. please rebase your branch if not and never merge from master

@aniketpati1121 aniketpati1121 force-pushed the fix-knative-pdb-single-replica branch from 999f749 to 68523a9 Compare January 5, 2026 17:25
@aniketpati1121
Copy link
Contributor Author

Hello, please make sure that you are on the latest master branch with the Knative 1.20 commit. please rebase your branch if not and never merge from master

Rebased onto latest master (Knative 1.20) — PR is now up-to-date and ready for review.

@aniketpati1121
Copy link
Contributor Author

@juliusvonkohout @kimwnasptd I’ve updated the changes. Please review them

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Jan 10, 2026

/hold
Thank you for the PR. Please never ever change the upstream folder . It is managed by the synchronization scripts in /scripts. It is synchronized from Knative. You need to instead patch it in the overlays. For example here for knative-serving https://github.com/aniketpati1121/manifests/blob/fix-knative-pdb-single-replica/common/knative/knative-serving/base/kustomization.yaml and we need to see which patches we can drop. Maybe we can remove the seccompprofile patches for example.

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Jan 10, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Knative Core Component PDB minAvailable: 80% Causes Drain Failures with Single Replica Deployments

3 participants