-
Notifications
You must be signed in to change notification settings - Fork 1k
Enable model-registry with UI by default #3318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome to the Kubeflow Manifests Repository Thanks for opening your first PR. Your contribution means a lot to the Kubeflow community. Before making more PRs: Community Resources:
Thanks again for helping to improve Kubeflow. |
|
hey @juliusvonkohout can you just review this pr. |
I am still on vacation, but maybe @tarilabs can help sooner. Are you sure that the catalog and everything is properly exposed in the dashboard UI @Raakshass? Do you mind sharing screenshots? Think of how we expose Kserve models web application in the dashboard. |
|
@Raakshass are you sure that it is properly exposed similar to the kserve models web application (endpoints) in the dashboard UI? I would like to see screenshots of the dashboard and the actual UI changes you made. Please check the original issue and related ones in the Model-Registry git repository. I think you are missing 80% of the work. |
This change enables the model-registry server and UI components in the default Kubeflow installation (example/kustomization.yaml). Components added: - Model Registry Server with PostgreSQL database (overlays/postgres) - Model Registry UI with Istio networking (options/ui/overlays/istio) This resolves issue kubeflow#3047 by following the same pattern used for enabling Spark Operator in PR kubeflow#3131. Signed-off-by: siddhant jain <[email protected]>
Signed-off-by: siddhant jain <[email protected]>
Signed-off-by: siddhant jain <[email protected]>
6b078df to
7f88e4f
Compare
|
could you kindly share screenshot with @ederign as Julius suggested please on this thread? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the upstream folder that will be automatically overwritten. Please use an overlay such as https://github.com/kubeflow/manifests/blob/7f88e4f9ffac06d897916644f63d5ad24924b123/applications/centraldashboard/overlays/oauth2-proxy/kustomization.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure julius!
|
Hey @ederign @juliusvonkohout @tarilabs, I’ve been following this PR and the related issue for a few days and thought I could jump in to help move things forward. I’d really appreciate a review when you get a chance. Thanks! |
|
I've commented on #3323 |
|
Hi @juliusvonkohout @tarilabs — addressing the feedback about showing the actual dashboard/UI change. What changed in this update
Why this changeKubeflow’s documentation for Model Registry installation and dashboard customization indicates the Model Registry entry should be added to the Central Dashboard configuration so it appears in the sidebar menu. Verification status
If you’d like the menu item to also include |
|
I think you can use a general named one called applications/centraldashboard/overlays/kustomization.yaml We should also merge https://github.com/kubeflow/manifests/blob/master/applications/centraldashboard/overlays/oauth2-proxy/kustomization.yaml into that because oauth2-proxy is anyway mandatory. |
Signed-off-by: Siddhant Jain <[email protected]>
26abe05 to
6c83297
Compare
|
@juliusvonkohout Refactor complete! |

Summary of Changes
This change enables the model-registry server and UI components in the default Kubeflow installation (
example/kustomization.yaml).Components added:
overlays/postgres)options/ui/overlays/istio)This implementation follows the same pattern used for enabling Spark Operator in PR #3131, ensuring consistency with existing Kubeflow component integrations.
Dependencies
No external dependencies. This PR uses existing upstream manifests from
applications/model-registry/that are already present in the repository.Related Issues
Closes #3047
This resolves the long-standing request to enable model-registry by default. The Spark Operator portion of the original issue was completed in PR #3131, and this PR completes the model-registry portion.
Contributor Checklist
Additional Context:
This PR adds only 5 lines to
example/kustomization.yaml(plus comments), making it a minimal and focused change. The selected overlays (postgresfor the server andistiofor the UI) are specifically designed for Kubeflow deployments and include proper Istio integration for authentication and networking.