-
Notifications
You must be signed in to change notification settings - Fork 41
add support for application queries without server name #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Manabu McCloskey <[email protected]>
62a7432 to
236e53a
Compare
vara-bonthu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
| export PATH="$HOME/.local/bin:$PATH" | ||
| echo "✅ uv installed! Please restart your terminal or run: export PATH=\"\$HOME/.local/bin:\$PATH\"" | ||
| echo "✅ uv installed! Please restart your terminal or run: exPORT PATH=\"\$HOME/.local/bin:\$PATH\"" | ||
| else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to make everything in capital "EXPORT"?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vara-bonthu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| limit=limit, | ||
| ) | ||
|
|
||
| if server: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔄 Pull Request
📝 Description
The current MCP server requires users to explicitly specify server names in tool calls, creating UX friction where LLMs must know which server contains specific applications before making requests. This PR allows for spark applications to be queried without explicitly specifying server names.
• Added ApplicationDiscovery class with TTL cache (5min default)
• Searches all servers for applications when server not specified
I've also update e2e tests. I had to:
🎯 Type of Change