Skip to content

Conversation

@nabuskey
Copy link
Collaborator

@nabuskey nabuskey commented Sep 16, 2025

🔄 Pull Request

📝 Description

The current MCP server requires users to explicitly specify server names in tool calls, creating UX friction where LLMs must know which server contains specific applications before making requests. This PR allows for spark applications to be queried without explicitly specifying server names.

• Added ApplicationDiscovery class with TTL cache (5min default)
• Searches all servers for applications when server not specified

I've also update e2e tests. I had to:

  • update the task file and scripts to accept variables like event directory and container name
  • add a simple example job that is used by the second spark history server

🎯 Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📖 Documentation update
  • 🧪 Test improvement
  • 🔧 Refactoring (no functional changes)

Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

export PATH="$HOME/.local/bin:$PATH"
echo "✅ uv installed! Please restart your terminal or run: export PATH=\"\$HOME/.local/bin:\$PATH\""
echo "✅ uv installed! Please restart your terminal or run: exPORT PATH=\"\$HOME/.local/bin:\$PATH\""
else
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to make everything in capital "EXPORT"?

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 981d2fc into kubeflow:main Sep 16, 2025
6 checks passed
@nabuskey nabuskey deleted the server-naming branch September 16, 2025 21:37
limit=limit,
)

if server:
Copy link

@yanivkrol yanivkrol Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi I'm trying to rebase #92 and something in this if doesn't make sense to me.
In case we have both default and some other servers configured, I can not list the applications of the default server only.
This is in contrast to all other tools where if not server then default server
@nabuskey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants