Add capability of disabling tools #119
Open
+350
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zemin-piao <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
nabuskey
reviewed
Sep 29, 2025
Comment on lines
+34
to
+51
| disabled_tools_env = os.getenv("SHS_GLOBAL_DISABLED_TOOLS", "") | ||
| if disabled_tools_env: | ||
| disabled_tools = [tool.strip() for tool in disabled_tools_env.split(",")] | ||
| if tool_name in disabled_tools: | ||
| return False | ||
|
|
||
| # Check configuration file | ||
| try: | ||
| config = Config.from_file(config_path) | ||
|
|
||
| # Check if any server has this tool disabled | ||
| for server_config in config.servers.values(): | ||
| if tool_name in server_config.disabled_tools: | ||
| return False | ||
|
|
||
| except Exception as e: | ||
| logger.error(f"Error loading configuration and loading disabled tools: {e}") | ||
| return True |
Collaborator
There was a problem hiding this comment.
Possible to use the settings object for this instead?
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔄 Pull Request
📝 Description
Add capability of disabling tools.
When integrating with multiple (N) spark history servers, the number of tools mcp server provides will be 18*N which is pretty high. It produces some verbosity for users listing available mcp tools.
🎯 Type of Change
🧪 Testing
task test)🔬 Test Commands Run
🛠️ New Tools Added (if applicable)
new_tool_name📸 Screenshots (if applicable)
✅ Checklist
📚 Related Issues
Fixes #(issue number)
Related to #(issue number)
🤔 Additional Context
🎉 Thank you for contributing! Your effort helps make Spark monitoring more intelligent.