Skip to content

Conversation

@JLLeitschuh
Copy link
Contributor

Removed DANGEROUSLY_OMIT_AUTH=true from MCP Inspector commands.

The DANGEROUSLY_OMIT_AUTH=true allows any website visited by a developer to maliciously attack the MCP server running locally on the dev machine, achieving remote code execution.

https://www.tenable.com/blog/how-tenable-research-discovered-a-critical-remote-code-execution-vulnerability-on-anthropic

🔄 Pull Request

📝 Description

Brief description of changes and motivation.

🎯 Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📖 Documentation update
  • 🧪 Test improvement
  • 🔧 Refactoring (no functional changes)

🧪 Testing

  • ✅ All existing tests pass (task test)
  • 🔬 Tested with MCP Inspector
  • 📊 Tested with sample Spark data
  • 🚀 Tested with real Spark History Server (if applicable)

🔬 Test Commands Run

# Example:
# task test
# npx @modelcontextprotocol/inspector uv run -m spark_history_mcp.core.main

🛠️ New Tools Added (if applicable)

  • Tool Name: new_tool_name
  • Purpose: What it does
  • Usage: Example parameters

📸 Screenshots (if applicable)

✅ Checklist

  • 🔍 Code follows project style guidelines
  • 🧪 Added tests for new functionality
  • 📖 Updated documentation (README, TESTING.md, etc.)
  • 🔧 Pre-commit hooks pass
  • 📝 Added entry to CHANGELOG.md (if significant change)

📚 Related Issues

Fixes #(issue number)
Related to #(issue number)

🤔 Additional Context

This fixes a security vulnerability.


🎉 Thank you for contributing! Your effort helps make Spark monitoring more intelligent.

…file

Removed DANGEROUSLY_OMIT_AUTH=true from MCP Inspector commands.

The `DANGEROUSLY_OMIT_AUTH=true` allows any website visited by a developer to maliciously attack the MCP server running locally on the dev machine, achieving remote code execution.

https://www.tenable.com/blog/how-tenable-research-discovered-a-critical-remote-code-execution-vulnerability-on-anthropic

Signed-off-by: Jonathan Leitschuh <[email protected]>
@JLLeitschuh JLLeitschuh changed the title Remove DANGEROUSLY_OMIT_AUTH=true from MCP Inspector commands in Taskfile Remove DANGEROUSLY_OMIT_AUTH=true from MCP Inspector commands in Taskfile Oct 24, 2025
Copy link
Collaborator

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JLLeitschuh Thanks for the PR.

The MCP Inspector is included in the taskfile to make it easy for developers to get started quickly. However, it seems this can be taken advantage of as described in the link you've provided.

Co-authored-by: Manabu McCloskey <[email protected]>
Signed-off-by: Jonathan Leitschuh <[email protected]>
@nabuskey
Copy link
Collaborator

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nabuskey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a0e727b into kubeflow:main Oct 24, 2025
6 checks passed
@JLLeitschuh JLLeitschuh deleted the patch-1 branch October 24, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants