Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Vignesh Shankar <vigsh@protonmail.com>
b4066a6 to
901a4fc
Compare
Collaborator
|
We have Taskfile here: https://github.com/kubeflow/mcp-apache-spark-history-server/blob/main/Taskfile.yml It's used by https://taskfile.dev/, which I prefer over Make. Do you have problems using Task? I'd love to welcome contributions so any thoughts here are appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔄 Pull Request
📝 Description
Hey! I've been working on a feature (EMR serverless support) that unblocks a usecase of mine. Adding this Makefile helped me drive unit and end-to-end testing a lot easier. Hoping that it helps others?
🎯 Type of Change
🧪 Testing
task test)🔬 Test Commands Run
make test🛠️ New Tools Added (if applicable)
new_tool_name📸 Screenshots (if applicable)
✅ Checklist
📚 Related Issues
Fixes #(issue number)
Related to #(issue number)
🤔 Additional Context
🎉 Thank you for contributing! Your effort helps make Spark monitoring more intelligent.