Skip to content

Add makefile#149

Open
remo5000 wants to merge 1 commit intokubeflow:mainfrom
remo5000:push-umsvyqpnyqzq
Open

Add makefile#149
remo5000 wants to merge 1 commit intokubeflow:mainfrom
remo5000:push-umsvyqpnyqzq

Conversation

@remo5000
Copy link
Copy Markdown

🔄 Pull Request

📝 Description

Hey! I've been working on a feature (EMR serverless support) that unblocks a usecase of mine. Adding this Makefile helped me drive unit and end-to-end testing a lot easier. Hoping that it helps others?

🎯 Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📖 Documentation update
  • 🧪 Test improvement
  • 🔧 Refactoring (no functional changes)

🧪 Testing

  • ✅ All existing tests pass (task test)
  • 🔬 Tested with MCP Inspector
  • 📊 Tested with sample Spark data
  • 🚀 Tested with real Spark History Server (if applicable)

🔬 Test Commands Run

make test

🛠️ New Tools Added (if applicable)

  • Tool Name: new_tool_name
  • Purpose: What it does
  • Usage: Example parameters

📸 Screenshots (if applicable)

✅ Checklist

  • 🔍 Code follows project style guidelines
  • 🧪 Added tests for new functionality
  • 📖 Updated documentation (README, TESTING.md, etc.)
  • 🔧 Pre-commit hooks pass
  • 📝 Added entry to CHANGELOG.md (if significant change)

📚 Related Issues

Fixes #(issue number)
Related to #(issue number)

🤔 Additional Context


🎉 Thank you for contributing! Your effort helps make Spark monitoring more intelligent.

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nabuskey for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Vignesh Shankar <vigsh@protonmail.com>
@remo5000 remo5000 force-pushed the push-umsvyqpnyqzq branch from b4066a6 to 901a4fc Compare March 19, 2026 21:48
@nabuskey
Copy link
Copy Markdown
Collaborator

We have Taskfile here: https://github.com/kubeflow/mcp-apache-spark-history-server/blob/main/Taskfile.yml

It's used by https://taskfile.dev/, which I prefer over Make.

Do you have problems using Task? I'd love to welcome contributions so any thoughts here are appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants