feat: added unit test files to frontend #1312
Conversation
| export const isRedHatRegistryUri = (uri: string): boolean => uri.startsWith('oci://example.io/'); // TODO: Change this to a proper check | ||
|
|
||
| export const isRedHatRegistryUri = (uri: string): boolean => | ||
| uri.startsWith('oci://registry.redhat.io/'); |
There was a problem hiding this comment.
Can we avoid hard code red hat here?
|
/assign @lucferbux |
|
Everything looks great, @rsun19 once you fix that would be ready to go (remember not porting rhoai related code) |
@ederign @lucferbux Should I just remove the whole function then? |
|
Great question tbh, we can parametrize it, change it to "isCompanyUri" and the string for company can be an env variable, so we got a default upstream and then we can override it downstream with |
|
I did something like |
Signed-off-by: rsun19 <[email protected]>
Signed-off-by: rsun19 <[email protected]>
Signed-off-by: rsun19 <[email protected]>
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* added unit test files Signed-off-by: rsun19 <[email protected]> * fixed lint errors Signed-off-by: rsun19 <[email protected]> * updated uri function Signed-off-by: rsun19 <[email protected]> --------- Signed-off-by: rsun19 <[email protected]> Signed-off-by: Taj010 <[email protected]>
* added unit test files Signed-off-by: rsun19 <[email protected]> * fixed lint errors Signed-off-by: rsun19 <[email protected]> * updated uri function Signed-off-by: rsun19 <[email protected]> --------- Signed-off-by: rsun19 <[email protected]> Signed-off-by: Taj010 <[email protected]>
3 participants
Description
Ported https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/pages/modelRegistrySettings/__tests__/ModelRegistryTableRowStatus.spec.tsx and https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/pages/modelRegistry/screens/__tests__/utils.spec.ts from the midstream
How Has This Been Tested?
Unit tests passing
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes