Skip to content

add rhec source & pull rhec models using graphql #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
google-oss-prow merged 13 commits into from
Jul 22, 2025
Merged

add rhec source & pull rhec models using graphql #1330

google-oss-prow merged 13 commits into from
Jul 22, 2025

Conversation

@adysenrothman
Copy link
Contributor

@adysenrothman adysenrothman commented Jul 17, 2025 •
edited
Loading

This PR adds the Red Hat Ecosystem Catalog as a source to the model catalog and adds functionality to retrieve models using RHEC graphql.

Description

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

dhirajsb
dhirajsb reviewed Jul 18, 2025
View reviewed changes
@google-oss-prow google-oss-prow bot added size/XXL and removed size/L labels Jul 18, 2025
@adysenrothman
add testing
18e5a1a 
Signed-off-by: Adysen Rothman <[email protected]>
@adysenrothman
cleanup logs and todo
48356d9 
Signed-off-by: Adysen Rothman <[email protected]>
@adysenrothman adysenrothman marked this pull request as ready for review July 18, 2025 16:20
@google-oss-prow google-oss-prow bot requested review from Al-Pragliola and Tomcli July 18, 2025 16:20
@adysenrothman
rm temp placeholder
ff914b0 
Signed-off-by: Adysen Rothman <[email protected]>
pboyd
pboyd reviewed Jul 18, 2025
View reviewed changes
Copy link
Member

@pboyd pboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just one thing, can you add a rule to catalog/Makefile to generate the GraphQL client?

dhirajsb
dhirajsb suggested changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@dhirajsb dhirajsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need targets in Makefile for graphql source and code generation.

@adysenrothman
add graphql gen code to makefile
5fa2504 
Signed-off-by: Adysen Rothman <[email protected]>
@adysenrothman
add makefule targets
8c378fc 
Signed-off-by: Adysen Rothman <[email protected]>
@adysenrothman
resolve deps
fb27929 
Signed-off-by: Adysen Rothman <[email protected]>
@adysenrothman
Merge branch 'main' into get-rhec-models
679114f 
Signed-off-by: Adysen Rothman <[email protected]>
pboyd
pboyd approved these changes Jul 18, 2025
View reviewed changes
Copy link
Member

@pboyd pboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 18, 2025
dhirajsb
dhirajsb suggested changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@dhirajsb dhirajsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link the genqclient/README.md from main README.md with a brief explanation of its purpose?

@google-oss-prow google-oss-prow bot removed the lgtm label Jul 18, 2025
@adysenrothman
Copy link
Contributor Author

adysenrothman commented Jul 18, 2025 •
edited
Loading

Can we link the genqclient/README.md from main README.md with a brief explanation of its purpose?

Will be adding a full README to the /catalog path in a separate pr with more information on model catalog as a whole and can add detail on the client.

dhirajsb
dhirajsb approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@dhirajsb dhirajsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 18, 2025
tarilabs
tarilabs reviewed Jul 21, 2025
View reviewed changes
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @adysenrothman !
I know it's minor comment, but I believe we need to contextualize this for upstream please, otherwise lgtm too

@google-oss-prow google-oss-prow bot removed the lgtm label Jul 21, 2025
@adysenrothman
Merge branch 'main' into get-rhec-models
f32c6d5 
Signed-off-by: Adysen Rothman <[email protected]>
@adysenrothman
work vendor
3d2b082 
Signed-off-by: Adysen Rothman <[email protected]>
@Al-Pragliola
Copy link
Contributor

Al-Pragliola commented Jul 22, 2025

looks good to me too

/lgtm

/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jul 22, 2025
@google-oss-prow
Copy link

google-oss-prow bot commented Jul 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Al-Pragliola

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit b59b25b into kubeflow:main Jul 22, 2025
19 checks passed
@tarilabs tarilabs mentioned this pull request Jul 23, 2025
Merged
Taj010 pushed a commit to Taj010/model-registry that referenced this pull request Aug 8, 2025
@adysenrothman @Taj010
add rhec source & pull rhec models using graphql (kubeflow#1330)
95d4f8e 
* add rhec source & pull rhec models using graphql

Signed-off-by: Adysen Rothman <[email protected]>

* replace graphql client & update source.yaml

Signed-off-by: Adysen Rothman <[email protected]>

* add testing

Signed-off-by: Adysen Rothman <[email protected]>

* cleanup logs and todo

Signed-off-by: Adysen Rothman <[email protected]>

* rm temp placeholder

Signed-off-by: Adysen Rothman <[email protected]>

* add graphql gen code to makefile

Signed-off-by: Adysen Rothman <[email protected]>

* add makefule targets

Signed-off-by: Adysen Rothman <[email protected]>

* resolve deps

Signed-off-by: Adysen Rothman <[email protected]>

* add context to genqlient and rhec sources

Signed-off-by: Adysen Rothman <[email protected]>

* work vendor

Signed-off-by: Adysen Rothman <[email protected]>

---------

Signed-off-by: Adysen Rothman <[email protected]>
Signed-off-by: Taj010 <[email protected]>
Taj010 pushed a commit to Taj010/model-registry that referenced this pull request Aug 8, 2025
@adysenrothman @Taj010
add rhec source & pull rhec models using graphql (kubeflow#1330)
eb44c6c 
* add rhec source & pull rhec models using graphql

Signed-off-by: Adysen Rothman <[email protected]>

* replace graphql client & update source.yaml

Signed-off-by: Adysen Rothman <[email protected]>

* add testing

Signed-off-by: Adysen Rothman <[email protected]>

* cleanup logs and todo

Signed-off-by: Adysen Rothman <[email protected]>

* rm temp placeholder

Signed-off-by: Adysen Rothman <[email protected]>

* add graphql gen code to makefile

Signed-off-by: Adysen Rothman <[email protected]>

* add makefule targets

Signed-off-by: Adysen Rothman <[email protected]>

* resolve deps

Signed-off-by: Adysen Rothman <[email protected]>

* add context to genqlient and rhec sources

Signed-off-by: Adysen Rothman <[email protected]>

* work vendor

Signed-off-by: Adysen Rothman <[email protected]>

---------

Signed-off-by: Adysen Rothman <[email protected]>
Signed-off-by: Taj010 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarilabs tarilabs tarilabs left review comments

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@rareddy rareddy Awaiting requested review from rareddy

@Al-Pragliola Al-Pragliola Awaiting requested review from Al-Pragliola

@Tomcli Tomcli Awaiting requested review from Tomcli

+2 more reviewers

@pboyd pboyd pboyd approved these changes

@dhirajsb dhirajsb dhirajsb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pboyd pboyd

@dhirajsb dhirajsb

@Al-Pragliola Al-Pragliola

Labels

approved Area/Manifests lgtm size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adysenrothman @Al-Pragliola @pboyd @dhirajsb @tarilabs