-
Notifications
You must be signed in to change notification settings - Fork 151
feat: migrate "Regression" user stories from Robot to pytest #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate "Regression" user stories from Robot to pytest #1332
Conversation
- Add structured error message tests for malformed model data (migrated from Robot) - Test API returns proper error messages for malformed RegisteredModel and ModelVersion requests - for both `code` and `message` - Clean ups/linting Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
fege
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
bringing this is /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…w#1332) * feat: migrate "Regression" user stories from Robot to pytest - Add structured error message tests for malformed model data (migrated from Robot) - Test API returns proper error messages for malformed RegisteredModel and ModelVersion requests - for both `code` and `message` - Clean ups/linting Signed-off-by: Matteo Mortari <[email protected]> * add comment to Robot Signed-off-by: Matteo Mortari <[email protected]> * linting Signed-off-by: Matteo Mortari <[email protected]> --------- Signed-off-by: Matteo Mortari <[email protected]> Signed-off-by: Taj010 <[email protected]>
…w#1332) * feat: migrate "Regression" user stories from Robot to pytest - Add structured error message tests for malformed model data (migrated from Robot) - Test API returns proper error messages for malformed RegisteredModel and ModelVersion requests - for both `code` and `message` - Clean ups/linting Signed-off-by: Matteo Mortari <[email protected]> * add comment to Robot Signed-off-by: Matteo Mortari <[email protected]> * linting Signed-off-by: Matteo Mortari <[email protected]> --------- Signed-off-by: Matteo Mortari <[email protected]> Signed-off-by: Taj010 <[email protected]>
Description
codeandmessagefollow-up from #1331
How Has This Been Tested?
local
make test-e2eMerge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes