Skip to content

Fix artifacts fetched twice on model version details page #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
google-oss-prow merged 2 commits into from
Aug 4, 2025
Merged

Fix artifacts fetched twice on model version details page #1333

google-oss-prow merged 2 commits into from
Aug 4, 2025

Conversation

@manaswinidas
Copy link
Contributor

@manaswinidas manaswinidas commented Jul 18, 2025 •
edited
Loading

Description

Upstream port of opendatahub-io/odh-dashboard#4206

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@google-oss-prow google-oss-prow bot requested review from Al-Pragliola and pboyd July 18, 2025 12:26
@YuliaKrimerman
Copy link
Contributor

YuliaKrimerman commented Jul 23, 2025

/lgtm

@google-oss-prow
Copy link

google-oss-prow bot commented Jul 23, 2025

@YuliaKrimerman: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@manaswinidas manaswinidas force-pushed the fix-artifacts-fetched-twice branch from 3edfc34 to dbd65fd Compare July 26, 2025 06:35
@lucferbux
Copy link
Contributor

lucferbux commented Jul 29, 2025

@manaswinidas can you fix the test? once it's fixed everything looks great, we can merge it.

@lucferbux
Copy link
Contributor

lucferbux commented Jul 30, 2025

/lgtm

@lucferbux
Copy link
Contributor

lucferbux commented Jul 30, 2025

/approve

@manaswinidas manaswinidas force-pushed the fix-artifacts-fetched-twice branch from dbd65fd to d911969 Compare July 31, 2025 14:35
@google-oss-prow google-oss-prow bot removed the lgtm label Jul 31, 2025
@manaswinidas
Fix Cypress tests
3236533 
Signed-off-by: manaswinidas <[email protected]>
@mturley
Copy link
Contributor

mturley commented Aug 1, 2025

/lgtm

@google-oss-prow
Copy link

google-oss-prow bot commented Aug 1, 2025

@mturley: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mturley
Copy link
Contributor

mturley commented Aug 1, 2025

right 😅

@lucferbux
Copy link
Contributor

lucferbux commented Aug 4, 2025

/approve

@lucferbux
Copy link
Contributor

lucferbux commented Aug 4, 2025

/lgtm

@google-oss-prow
Copy link

google-oss-prow bot commented Aug 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added the lgtm label Aug 4, 2025
@google-oss-prow google-oss-prow bot merged commit 8fc7313 into kubeflow:main Aug 4, 2025
20 checks passed
@Al-Pragliola Al-Pragliola mentioned this pull request Aug 4, 2025
Merged
Taj010 pushed a commit to Taj010/model-registry that referenced this pull request Aug 8, 2025
@manaswinidas @Taj010
Fix artifacts fetched twice on model version details page (kubeflow#1333
6d92944 
)

* Fix artifacts fetched twice on model version details page

Signed-off-by: manaswinidas <[email protected]>

* Fix Cypress tests

Signed-off-by: manaswinidas <[email protected]>

---------

Signed-off-by: manaswinidas <[email protected]>
Taj010 pushed a commit to Taj010/model-registry that referenced this pull request Aug 8, 2025
@manaswinidas @Taj010
Fix artifacts fetched twice on model version details page (kubeflow#1333
a911ce1 
)

* Fix artifacts fetched twice on model version details page

Signed-off-by: manaswinidas <[email protected]>

* Fix Cypress tests

Signed-off-by: manaswinidas <[email protected]>

---------

Signed-off-by: manaswinidas <[email protected]>
Signed-off-by: Taj010 <[email protected]>
@tarilabs tarilabs mentioned this pull request Nov 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Al-Pragliola Al-Pragliola Awaiting requested review from Al-Pragliola

@pboyd pboyd Awaiting requested review from pboyd

Assignees

@lucferbux lucferbux

Labels

approved Area/UI lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@manaswinidas @YuliaKrimerman @lucferbux @mturley