fix: remove incorrect prepare workflow call in build-and-push-image.yml #1336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
follow-up to kubeflow#1334 The build-and-push-image workflow was incorrectly calling the prepare.yml as a step action instead of using it as a reusable workflow. This caused the error "Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under .github/workflows/prepare.yml". Example: https://github.com/kubeflow/model-registry/actions/runs/16379707719/job/46288348593 The prepare job is already correctly called at the top of the jobs section, so the duplicate call in the steps was unnecessary and likely the cause of the failure. Signed-off-by: Matteo Mortari <[email protected]>
Al-Pragliola
approved these changes
Jul 19, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Al-Pragliola The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Taj010
pushed a commit
to Taj010/model-registry
that referenced
this pull request
Aug 8, 2025
…ml (kubeflow#1336) follow-up to kubeflow#1334 The build-and-push-image workflow was incorrectly calling the prepare.yml as a step action instead of using it as a reusable workflow. This caused the error "Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under .github/workflows/prepare.yml". Example: https://github.com/kubeflow/model-registry/actions/runs/16379707719/job/46288348593 The prepare job is already correctly called at the top of the jobs section, so the duplicate call in the steps was unnecessary and likely the cause of the failure. Signed-off-by: Matteo Mortari <[email protected]> Signed-off-by: Taj010 <[email protected]>
Taj010
pushed a commit
to Taj010/model-registry
that referenced
this pull request
Aug 8, 2025
…ml (kubeflow#1336) follow-up to kubeflow#1334 The build-and-push-image workflow was incorrectly calling the prepare.yml as a step action instead of using it as a reusable workflow. This caused the error "Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under .github/workflows/prepare.yml". Example: https://github.com/kubeflow/model-registry/actions/runs/16379707719/job/46288348593 The prepare job is already correctly called at the top of the jobs section, so the duplicate call in the steps was unnecessary and likely the cause of the failure. Signed-off-by: Matteo Mortari <[email protected]> Signed-off-by: Taj010 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
follow-up to #1334
The build-and-push-image workflow was incorrectly calling the prepare.yml as a step action instead of using it as a reusable workflow. This caused the error "Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under .github/workflows/prepare.yml".
Example: https://github.com/kubeflow/model-registry/actions/runs/16379707719/job/46288348593
The prepare job is already correctly called at the top of the jobs section, so the duplicate call in the steps was unnecessary and likely the cause of the failure.
How Has This Been Tested?
cannot be tested locally ci/GHA, we need to fix on merge-to-main.
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes