Types and mocks update for Catalog Source Status

[manaswinidas]

Description

Added types and mocks for status of a catalog source

Proposed OpenAPI changes PR: #1870

How Has This Been Tested?

Tested using the following curl command while running the BFF in mock mode. I used make run PORT=4000 MOCK_K8S_CLIENT=true MOCK_MR_CLIENT=true MOCK_MR_CATALOG_CLIENT=true DEV_MODE=true DEPLOYMENT_MODE=standalone in bff folder and ran curl -X GET "http://localhost:4000/api/v1/model_catalog/sources?namespace=kubeflow" \ -H "kubeflow-userid: [email protected]" in another terminal and got the following result with status

Merge criteria:

• All the commits have been signed-off (To pass the DCO check)

• The commits have meaningful messages
• Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work.
• Code changes follow the kubeflow contribution guidelines.
• For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

• The developer has added tests or explained why testing cannot be added.
• Included any necessary screenshots or gifs if it was a UI change.
• Verify that UI/UX changes conform the UX guidelines for Kubeflow.

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from manaswinidas. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• clients/ui/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[manaswinidas]

@mturley OpenAPI spec catalog.yaml states the status will be an enum but error will be an object, right?

CatalogSourceStatus:
      description: |-
        Operational status of a catalog source.
        - `available`: The source is functioning correctly and models can be retrieved
        - `error`: The source is experiencing issues and cannot provide models
        - `disabled`: The source has been intentionally disabled
      enum:
        - available
        - error
        - disabled
      type: string

[ppadti]

@manaswinidas We also need to update the mod-arch.yaml file as well with status and error for /sources endpoint.

Also @mturley quick question - looking at this PR: : #1870 - we will also have includedModels and excludedModels as well on CatalogSource?

[ppadti]

we will also have Error property- we need to add that here. Also need to update the mocks with this

[google-oss-prow]

@ppadti: changing LGTM is restricted to collaborators

In response to this:

We also need to update the mod-arch.yaml file as well with status and error for /sources endpoint.

Also @mturley quick question - looking at this PR: : #1870 - we will also have includedModels and excludedModels as well on CatalogSource?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mturley]

@mturley OpenAPI spec catalog.yaml states the status will be an enum but error will be an object, right?

@manaswinidas looking at the spec I think status is an enum and then error is just a string.

Also @mturley quick question - looking at this PR: : #1870 - we will also have includedModels and excludedModels as well on CatalogSource?

@ppadti that's interesting, yeah it looks like we'll have the allow/disallow input values there. I don't think we'll need to use that though since it's also in the configmap