-
Notifications
You must be signed in to change notification settings - Fork 145
Catalog: Round latency to 2 decimal places, remove commented out code for average accuracy on cards #1898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…age accuracy on cards Signed-off-by: Mike Turley <[email protected]>
manaswinidas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
@mturley There's a linting error |
Signed-off-by: Mike Turley <[email protected]>
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@manaswinidas thanks, fixed |
|
@mturley Cypress test failing |
Signed-off-by: Mike Turley <[email protected]>
|
@manaswinidas ugh sorry, fixed again |
|
/retest |
Description
We neglected to call the
formatLatencyutil when displaying latency metrics on the cards in the catalog landing page. This fixes that, truncating the number to 2 decimal places.(screenshot is outdated mock data, disregard the logo)

Also, we had left commented-out code around this card area for the average accuracy metric, which we expected to reinstate later but has now been excluded from the design. Removing that dead code while I'm in here.
How Has This Been Tested?
Ran in mock mode, observed that the number is rounded correctly.
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes