Skip to content

Conversation

@YuliaKrimerman
Copy link
Contributor

Description

Implemented delete functionality for catalog sources with a confirmation modal that requires users to type the source name before deletion is allowed.

UI Changes:

Screen.Recording.2025-11-24.at.2.40.39.PM.mov

How Has This Been Tested?

Manual Testing:

  • ✅ Verified delete modal opens when clicking "Delete source" action

Automated Testing:

  • ✅ Added Cypress tests for delete modal functionality:

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)

  • The commits have meaningful messages

  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).

  • The developer has manually tested the changes and verified that the changes work.

  • Code changes follow the kubeflow contribution guidelines.

  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes:

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Note: Remember to add an actual screenshot from your testing to replace the placeholder!

Signed-off-by: Yulia Krimerman <[email protected]>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manaswinidas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested a review from pboyd November 24, 2025 19:54
@github-actions github-actions bot added Area/UI and removed size/L labels Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant