-
Notifications
You must be signed in to change notification settings - Fork 151
KEP GHA alignment for container image Signature and Attestation #2032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…nd Attestation Signed-off-by: Matteo Mortari <[email protected]>
… workflows Align all GitHub Actions workflows for container image builds with: - Multi-arch support (linux/arm64, linux/amd64) via QEMU - Standardized metadata generation using docker/metadata-action - Image signing with cosign using digest references - SBOM generation using anchore/sbom-action (SPDX format) - SBOM attestation using cosign attest (replacing cosign attach) - Consistent permissions (id-token, actions, contents) This ensures all container images are signed and have SBOMs attested in a cosign-compatible format, improving supply chain security. Co-Authored-By: Claude <[email protected]> Signed-off-by: Matteo Mortari <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Matteo Mortari <[email protected]>
ederign
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tarilabs this lgtm, just a minor nitpick. Shall we merge it? Or should we wait for others chime in?
Co-authored-by: Eder Ignatowicz <[email protected]> Signed-off-by: Matteo Mortari <[email protected]>
|
it was in the Dec 22 meeting, and in the agenda's for today's meeting. To me we can merge it next week as we're planning to cut a release this week. |
|
@tarilabs lgtm then, feel free to merge when it's suitable for the release. |
Description
followup to
Standardize GitHub Actions workflows to use
docker/build-push-actionfor multi-arch builds with metadata,anchore/sbom-actionfor SPDX SBOM generation, and cosign attestation for signed SBOMs.Minor note: called KEP 2 since we currently we have KEP 1 under review here.
How Has This Been Tested?
see KEP markdown for details.
we will need to observe the GHA workflow aligned once merged, possibly after a release so to not jeopardize a release's process.
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes