Skip to content

Conversation

@Taj010
Copy link
Contributor

@Taj010 Taj010 commented Jan 16, 2026

Description

For the Model Catalog:

  • The extractValidatedModelMetrics util falls back to hard-coded defaults (fake metrics) is changed to a description fallback
  • The spinners is changed to skeletons when loading artifacts inside the body of each cards for validated models on the catalog landing page
  • Fix the 500 error state coming from the BFF when loading those artifacts to have it fall back to the non-validated-model version of the card and have a toast notification with "error loading performance artifacts for model"with API error message.

How Has This Been Tested?

Updated validatedModelUtils.spec.ts to verify extractValidatedModelMetrics returns null when performance artifacts array is empty or index is out of bounds

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign alexcreasy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Taj010 <rsheen003@gmail.com>
Signed-off-by: Taj010 <rsheen003@gmail.com>
Signed-off-by: Taj010 <rsheen003@gmail.com>
Signed-off-by: Taj010 <rsheen003@gmail.com>
@Taj010 Taj010 changed the title Replace fake metrics with description fallback and change loading states for validated model cards Replace fake metrics with description fallback and change loading and error states for validated model cards Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant