Added edge case for re-enabling source on the MC settings page #2132
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix catalog source status feedback when re-enabling after disable
Description
Fixed a UI feedback issue where re-enabling a catalog source after disabling it showed "-" instead of "Starting" status, providing no feedback that the source was loading.
Root Cause:
When a catalog source is re-enabled:
enabled: truestatus: DISABLED(until loading completes)Solution:
Updated
CatalogSourceStatus.tsxto handle the ConfigMap/API mismatch. The component now shows "Starting" status when:enabled: true(checked at line 24)status: DISABLED(caught in switch statement)Code Changes:
enabled: false(line 24-26)DISABLEDcase is reached in switch statement, we knowenabled: truedue to early returnUser Experience:
How Has This Been Tested?
Merge criteria:
All the commits have been signed-off (To pass the
DCOcheck)The commits have meaningful messages
Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work.
Code changes follow the kubeflow contribution guidelines.
For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label
ok-to-testhas been added to the PR.If you have UI changes