Skip to content

Conversation

@YuliaKrimerman
Copy link
Contributor

Add Model Transfer Job Name and Resource Name Fields to Register and Store Flow

Description

This PR implements the Model transfer job name and resource name fields for the "Register and store" workflow in the Model Registry UI. (Currently behind a feature flag)
Screenshot 2026-01-21 at 1 29 31 PM

How Has This Been Tested?

Automated Tests

  • Cypress E2E tests: Added comprehensive test coverage in registerAndStore.cy.ts

Manual Testing

Verified in browser that:

  • Toggle shows correctly when RegistryStorage feature flag is enabled
  • Job name field appears in "Register and store" mode
  • "Edit resource name" link reveals the resource name field
  • Custom validation helper text displays correctly

Testing Instructions

  1. Enable the RegistryStorage feature flag
  2. Navigate to Model Registry → Register model (or Register version)
  3. Click the "Register and store" toggle
  4. Verify "Model transfer job name" field appears
  5. Enter a job name and verify it accepts input
  6. Click "Edit resource name" link
  7. Verify "Resource name" field appears with validation helper text
  8. Enter a resource name and verify it accepts input
  9. Switch back to "Register" toggle and verify job fields are hidden

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>
@google-oss-prow google-oss-prow bot requested review from jonburdo and pboyd January 21, 2026 18:50
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from yuliakrimerman. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant