Skip to content

Conversation

@Taj010
Copy link
Contributor

@Taj010 Taj010 commented Jan 26, 2026

Description

Initially when the rest button was applied in the Latency and Max RPS filters it would reapply default values and trigger filter updates instead of undoing unapplied changes. The Reset Button now restores the filter values that were active when the dropdown was opened, without applying any changes.

How Has This Been Tested?

Manual Testing

Verified in browser that in the Model Catalog when the Model performance view toggle is enabled and inside the performance insights tab for latency filter and MaxRPS filter

  • when the respective filter is applied and dropdown is opened again if the values has been changed (without applying them) and the Reset button is clicked it should restore to applied values and do not refresh.
  • When the dropdown is opened but no values have been changed and adjusted it should simply show the current applied values and not go back to default values.

Automated Tests

  • Cypress E2E tests: Adjusted the modelCatalog/modelCatalogTabs.cy.ts file to remove the the old 'should reset to default latency filter (TTFT P90) when filter is reset' and adjust it to where the reset should restore applied values test.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: Taj010 <rsheen003@gmail.com>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign alexcreasy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Taj010 <rsheen003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant