Fix Reset buttons behavior for Latency and Max RPS filters #2158
+38
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initially when the rest button was applied in the Latency and Max RPS filters it would reapply default values and trigger filter updates instead of undoing unapplied changes. The Reset Button now restores the filter values that were active when the dropdown was opened, without applying any changes.
How Has This Been Tested?
Manual Testing
Verified in browser that in the Model Catalog when the Model performance view toggle is enabled and inside the performance insights tab for latency filter and MaxRPS filter
Automated Tests
modelCatalog/modelCatalogTabs.cy.tsfile to remove the the old 'should reset to default latency filter (TTFT P90) when filter is reset' and adjust it to where the reset should restore applied values test.Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes