chore: clean up owners file#2182
Conversation
|
I had left Andrey with the comment to have someone outside of company bus factor in. If you notice the yaml comment, is used in the GH to check consistency with the ACL, which imho is the most important. |
This cleans up the root OWNERS file to follow best-practices and more closely match the state of the kubeflow sdk file: https://github.com/kubeflow/sdk/blob/main/kubeflow/hub/OWNERS Specifically this does the following: - remove duplicate reviewers entries which are also in approvers: - andreyvelich - Al-Pragliola - pboyd Also see: kubeflow/sdk#244 (comment) Signed-off-by: Jon Burdo <jon@jonburdo.com>
5774c04 to
74afa13
Compare
Definitely agree, good catch! Rebased and updated so it's just to remove duplicates |
|
/lgtm |
tarilabs
left a comment
There was a problem hiding this comment.
I've noticed the added "note" at the beginning of this PR
I'd say for this iteration, this PR can move on.
I'd recommend adding a "linter" like already done for the KF/internal-acls to verify the Reviewer/Approver are "linted" to that files too :)
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Note
Going forward, changes to
OWNERSfor the Kubeflow Hub team should be made to both of these files:kubeflow/model-registryrootOWNERSfile:https://github.com/kubeflow/model-registry/blob/main/OWNERS
kubeflow/sdksub-module filekubeflow/hub/OWNERS:https://github.com/kubeflow/sdk/blob/main/kubeflow/hub/OWNERS
Description
This cleans up the root OWNERS file to follow best-practices and more closely match the state of the kubeflow sdk file: https://github.com/kubeflow/sdk/blob/main/kubeflow/hub/OWNERS
Specifically this does the following:
Also see: kubeflow/sdk#244 (comment)
How Has This Been Tested?
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes