Skip to content

chore: clean up owners file#2182

Merged
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
jonburdo:clean-up-owners-file
Feb 9, 2026
Merged

chore: clean up owners file#2182
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
jonburdo:clean-up-owners-file

Conversation

@jonburdo
Copy link
Copy Markdown
Member

@jonburdo jonburdo commented Feb 2, 2026

Note

Going forward, changes to OWNERS for the Kubeflow Hub team should be made to both of these files:

Description

This cleans up the root OWNERS file to follow best-practices and more closely match the state of the kubeflow sdk file: https://github.com/kubeflow/sdk/blob/main/kubeflow/hub/OWNERS

Specifically this does the following:

  • remove duplicate reviewers entries which are also in approvers:
    • andreyvelich
    • Al-Pragliola
    • pboyd

Also see: kubeflow/sdk#244 (comment)

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Copy link
Copy Markdown
Member

@pboyd pboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tarilabs
Copy link
Copy Markdown
Member

tarilabs commented Feb 3, 2026

I had left Andrey with the comment to have someone outside of company bus factor in. If you notice the yaml comment, is used in the GH to check consistency with the ACL, which imho is the most important.

This cleans up the root OWNERS file to follow best-practices and more
closely match the state of the kubeflow sdk file:
https://github.com/kubeflow/sdk/blob/main/kubeflow/hub/OWNERS

Specifically this does the following:
- remove duplicate reviewers entries which are also in approvers:
  - andreyvelich
  - Al-Pragliola
  - pboyd

Also see: kubeflow/sdk#244 (comment)

Signed-off-by: Jon Burdo <jon@jonburdo.com>
@jonburdo jonburdo force-pushed the clean-up-owners-file branch from 5774c04 to 74afa13 Compare February 3, 2026 16:30
@google-oss-prow google-oss-prow bot removed the lgtm label Feb 3, 2026
@jonburdo
Copy link
Copy Markdown
Member Author

jonburdo commented Feb 3, 2026

I had left Andrey with the comment to have someone outside of company bus factor in. If you notice the yaml comment, is used in the GH to check consistency with the ACL, which imho is the most important.

Definitely agree, good catch! Rebased and updated so it's just to remove duplicates

@Al-Pragliola
Copy link
Copy Markdown
Contributor

/lgtm

Copy link
Copy Markdown
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed the added "note" at the beginning of this PR

I'd say for this iteration, this PR can move on.

I'd recommend adding a "linter" like already done for the KF/internal-acls to verify the Reviewer/Approver are "linted" to that files too :)

@tarilabs
Copy link
Copy Markdown
Member

tarilabs commented Feb 9, 2026

/approve

@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 6fe3dca into kubeflow:main Feb 9, 2026
25 checks passed
@jonburdo jonburdo deleted the clean-up-owners-file branch February 10, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants