Skip to content

fix(catalog): enable independent scrolling for filter panel #2475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manaswinidas wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(catalog): enable independent scrolling for filter panel #2475

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
758c313
fix(catalog): enable independent scrolling for filter panel
manaswinidas Mar 25, 2026
729f7c2
Use PatternFly variant="sticky" instead of custom positioning
manaswinidas Mar 25, 2026
1451094
Prevent scrollbar from consuming sidebar width
manaswinidas Mar 25, 2026
820ceb7
Add padding to prevent content cutoff by scrollbar
manaswinidas Mar 25, 2026
bea36f9
Remove fixed minWidth from performance toggle card
manaswinidas Mar 26, 2026
2482bfa
Increase sidebar width to prevent text wrapping
manaswinidas Mar 31, 2026
dff599b
Fix TypeScript error: use inline style for sidebar width
manaswinidas Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/ui/frontend/src/app/pages/modelCatalog/components/ModelCatalogFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const ModelCatalogFilters: React.FC = () => {
filters && filterKey in filters ? filters : undefined;

return (
<Stack hasGutter>
<Stack hasGutter style={{ paddingRight: 'var(--pf-t--global--spacer--sm)' }}>
<ModelPerformanceViewToggleCard />
<TaskFilter filters={getFilterProps(ModelCatalogStringFilterKey.TASK)} />
<ProviderFilter filters={getFilterProps(ModelCatalogStringFilterKey.PROVIDER)} />
Expand Down
2 changes: 1 addition & 1 deletion clients/ui/frontend/src/app/pages/modelCatalog/screens/ModelCatalog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const ModelCatalog: React.FC = () => {
provideChildrenPadding
>
<Sidebar hasBorder hasGutter>
<SidebarPanel>
<SidebarPanel variant="sticky" style={{ maxHeight: '100vh', overflowY: 'auto' }}>
Copy link
Copy Markdown
Contributor

@Philip-Carneiro Philip-Carneiro Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that scrollbar consumes some width from the actual sidebar, so a little of the border of the things inside are cut out as the image bellow:

Image

<ModelCatalogFilters />
</SidebarPanel>
<SidebarContent>
Expand Down
Loading