fix(catalog): replace phantom yamlMCPArtifact struct with generated openapi.MCPArtifact#2512
Merged
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom Mar 30, 2026
Conversation
…penapi.MCPArtifact The custom yamlMCPArtifact struct had fields (Name, Type) not present in the OpenAPI spec and was missing timestamp fields (createTimeSinceEpoch, lastUpdateTimeSinceEpoch) that are defined in the spec. This caused silent data loss of artifact timestamps through the entire MCP server YAML loader pipeline. Replacing it with the generated apimodels.MCPArtifact type ensures struct-to-JSON fidelity and prevents field drift. Adds a round-trip test verifying timestamps survive ToMCPServerProviderRecord() serialization. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Chris Hambridge <chambrid@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pboyd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The custom yamlMCPArtifact struct had fields (Name, Type) not present in the OpenAPI spec and was missing timestamp fields (createTimeSinceEpoch, lastUpdateTimeSinceEpoch) that are defined in the spec. This caused silent data loss of artifact timestamps through the entire MCP server YAML loader pipeline. Replacing it with the generated apimodels.MCPArtifact type ensures struct-to-JSON fidelity and prevents field drift.
Adds a round-trip test verifying timestamps survive ToMCPServerProviderRecord() serialization.
How Has This Been Tested?
Unit tests
Loading manifest data
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes