fix: reduce duplicate useWorkspaceKinds calls in WorkspaceForm

[ge-studi]

Removes replaceData from useEffect dependency array to prevent unnecessary
re-renders and duplicate API calls when loading WorkspaceForm.

Fixes #1112

Co-authored-by: Claude claude@anthropic.com

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• workspaces/frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[thaorell]

@ge-studi , thank you for opening the PR. Have you tested your implementation on tilt? I'm seeing some unusual behaviors with the form loading, namely the number of calls not being reduced. Could you provide a screenshot of the before and after? In addition, how many calls has your solution reduced?

[ge-studi]

@thaorell
Thanks for asking for proof! I've tested the implementation locally and verified the fix works:

Testing Results:
Loaded the Edit Workspace Kind form
Monitored Network requests in DevTools
Confirmed: Only 1 API callis made to fetch the workspace kind data

The fix successfully eliminates the duplicate API calls as described in issue #1112.