feat(ws): Notebooks v2 add secrets to workspace creation properties #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hen Schwartz (EXT-Nokia) <[email protected]>
Signed-off-by: Hen Schwartz (EXT-Nokia) <[email protected]>
…mockup kubeflow#203 (kubeflow#237) * feat(ws): Notebooks 2.0 // Frontend // Workspace Kind Viewer // Live mockup kubeflow#203 Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> * feat(ws): Notebooks 2.0 // Frontend // Workspace Kind Viewer // Live mockup kubeflow#203 Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> * feat(ws): Notebooks 2.0 // Frontend // Workspace Kind Viewer // Live mockup kubeflow#203 Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> * feat(ws): Notebooks 2.0 // Frontend // Workspace Kind Viewer // Live mockup kubeflow#203 Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> * feat(ws): Notebooks 2.0 // Frontend // Workspace Kind Viewer // Live mockup kubeflow#203 Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> * feat(ws): Notebooks 2.0 // Frontend // Workspace Kind Viewer // Live mockup kubeflow#203 Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> * feat(ws): Notebooks 2.0 // Frontend // Workspace Kind Viewer // Live mockup kubeflow#203 Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> --------- Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> Co-authored-by: Liav Weiss (EXT-Nokia) <[email protected]>
…eflow#264) Signed-off-by: Jenny <[email protected]>
…eflow#264) Signed-off-by: Jenny <[email protected]>
Signed-off-by: Jenny <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thaorell
force-pushed
the
notebooks-v2-workspace-creation-secrets-select
branch
from
9c0a3ce to
de8fe2a
Compare
paulovmr
suggested changes
May 6, 2025
| } from '@patternfly/react-core'; | ||
| import { WorkSpaceSecret } from '~/shared/types'; | ||
|
|
||
| interface WorkspaceCreationSecretsProps { |
There was a problem hiding this comment.
Suggested change
| interface WorkspaceCreationSecretsProps { | |
| interface WorkspaceCreationPropertiesSecretsProps { |
| secrets: WorkSpaceSecret[]; | ||
| } | ||
|
|
||
| export interface WorkSpaceSecret { |
There was a problem hiding this comment.
Suggested change
| export interface WorkSpaceSecret { | |
| export interface WorkspaceSecret { |
| )} | ||
| </ExpandableSection> | ||
| {!isSecretsExpanded && ( | ||
| <div style={{ paddingLeft: '36px' }}> |
There was a problem hiding this comment.
Please consider adding a message here, similarly to volumes. @jenny-s51 Any suggestions on the message to use here?
| </Table> | ||
| )} | ||
| <Button variant="primary" onClick={() => setIsModalOpen(true)} style={{ marginTop: '1rem' }}> | ||
| Create Secrets |
There was a problem hiding this comment.
Suggested change
| Create Secrets | |
| Create Secret |
| Create Secrets | ||
| </Button> | ||
| <Modal isOpen={isModalOpen} onClose={clearForm} variant={ModalVariant.small}> | ||
| <ModalHeader |
There was a problem hiding this comment.
Please consider adding a description to the ModalHeader, similarly to volumes. @jenny-s51 Any suggestions on the message to use here?
Signed-off-by: Charles Thao <[email protected]>
thaorell
force-pushed
the
notebooks-v2-workspace-creation-secrets-select
branch
from
de8fe2a to
24c4046
Compare
|
/ok-to-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #267
related: depends on #262
Note:
defaultModeand stores it as decimal before submitting back to API2025_05_01-15_35_11.webm