-
Notifications
You must be signed in to change notification settings - Fork 43
chore: reference ghcr.io images in workspacekind yaml #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: notebooks-v2
Are you sure you want to change the base?
chore: reference ghcr.io images in workspacekind yaml #305
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Testing locally on a
|
Given we have migrated all our images from docker.io to ghcr.io - our `notebooks-v2` branch should reference the "proper" container registry. This commit updates the code to use: - `ghcr.io/kubeflow/kubeflow/notebook-servers` Affected areas: - `jupyterlab_scipy_180` and `jupyterlab_scipy_190` `imageConfig` entries - various test files Signed-off-by: Andy Stoneberg <[email protected]>
5249bcb
to
bae225e
Compare
Due diligence local verification: controller
backend
|
Given we have migrated all our images from docker.io to ghcr.io - our
sample/config
data should reference the "proper" container registry.This commit updates the
jupyterlab_scipy_180
andjupyterlab_scipy_190
imageConfig
entries to use:ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy