Skip to content

chore: reference ghcr.io images in workspacekind yaml #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andyatmiami
Copy link
Contributor

Given we have migrated all our images from docker.io to ghcr.io - our sample/config data should reference the "proper" container registry.

This commit updates the jupyterlab_scipy_180 and jupyterlab_scipy_190 imageConfig entries to use:

  • ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy

@andyatmiami
Copy link
Contributor Author

Testing locally on a kind cluster - I was able to verify these images are able to be pulled:

$ kubectl get events --sort-by='.lastTimestamp'

...
25m         Normal    Pulled                             pod/ws-jupyterlab-workspace-zlhhq-0             Successfully pulled image "ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy:v1.9.0" in 231ms (231ms including waiting). Image size: 962747238 bytes.
...
20m         Normal    Pulled                             pod/ws-jupyterlab-old-workspace-g285g-0         Successfully pulled image "ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy:v1.8.0" in 30.856s (30.856s including waiting). Image size: 1077429079 bytes.

Given we have migrated all our images from docker.io to ghcr.io - our `notebooks-v2` branch should reference the "proper" container registry.

This commit updates the code to use:
- `ghcr.io/kubeflow/kubeflow/notebook-servers`

Affected areas:
- `jupyterlab_scipy_180` and `jupyterlab_scipy_190` `imageConfig` entries
- various test files

Signed-off-by: Andy Stoneberg <[email protected]>
@andyatmiami andyatmiami force-pushed the chore/ghcr-image-refs branch from 5249bcb to bae225e Compare May 2, 2025 15:53
@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels May 2, 2025
@andyatmiami
Copy link
Contributor Author

Due diligence local verification:

controller

➜ controller/ git:(chore/ghcr-image-refs) $ gmake lint
/Users/astonebe/Development/Code/GitHub/kubeflow-notebooks/workspaces/controller/bin/golangci-lint run
➜ controller/ git:(chore/ghcr-image-refs) $ git status
On branch chore/ghcr-image-refs
Your branch is up to date with 'origin/chore/ghcr-image-refs'.

nothing to commit, working tree clean

➜ controller/ git:(chore/ghcr-image-refs) $ gmake test
Downloading sigs.k8s.io/controller-tools/cmd/[email protected]
/Users/astonebe/Development/Code/GitHub/kubeflow-notebooks/workspaces/controller/bin/controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
/Users/astonebe/Development/Code/GitHub/kubeflow-notebooks/workspaces/controller/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
go fmt ./...
go vet ./...
Downloading sigs.k8s.io/controller-runtime/tools/[email protected]
go: downloading sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-20250308055145-5fe7bb3edc86
go: downloading sigs.k8s.io/controller-runtime v0.19.7
KUBEBUILDER_ASSETS="/Users/astonebe/Development/Code/GitHub/kubeflow-notebooks/workspaces/controller/bin/k8s/1.31.0-darwin-arm64" go test $(go list ./... | grep -v /e2e) -coverprofile cover.out
	github.com/kubeflow/notebooks/workspaces/controller/api/v1beta1		coverage: 0.0% of statements
	github.com/kubeflow/notebooks/workspaces/controller/cmd		coverage: 0.0% of statements
	github.com/kubeflow/notebooks/workspaces/controller/test/utils		coverage: 0.0% of statements
ok  	github.com/kubeflow/notebooks/workspaces/controller/internal/controller	11.804s	coverage: 60.2% of statements
ok  	github.com/kubeflow/notebooks/workspaces/controller/internal/helper	0.716s	coverage: 14.6% of statements
ok  	github.com/kubeflow/notebooks/workspaces/controller/internal/webhook	10.203s	coverage: 90.1% of statements

➜ controller/ git:(chore/ghcr-image-refs) $ gmake test-e2e
/Users/astonebe/Development/Code/GitHub/kubeflow-notebooks/workspaces/controller/bin/controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
/Users/astonebe/Development/Code/GitHub/kubeflow-notebooks/workspaces/controller/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
go fmt ./...
go vet ./...
go test ./test/e2e/ -v -ginkgo.v
...
Ran 1 of 1 Specs in 169.946 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped

backend

➜ backend/ git:(chore/ghcr-image-refs) $ gmake lint
mkdir -p /Users/astonebe/Development/Code/GitHub/kubeflow-notebooks/workspaces/backend/bin
Downloading github.com/golangci/golangci-lint/cmd/[email protected]
/Users/astonebe/Development/Code/GitHub/kubeflow-notebooks/workspaces/backend/bin/golangci-lint run
➜ backend/ git:(chore/ghcr-image-refs) $ git status
On branch chore/ghcr-image-refs
Your branch is up to date with 'origin/chore/ghcr-image-refs'.

nothing to commit, working tree clean

$ gmake test
go fmt ./...
go vet ./...
Downloading sigs.k8s.io/controller-runtime/tools/[email protected]
KUBEBUILDER_ASSETS="/Users/astonebe/Development/Code/GitHub/kubeflow-notebooks/workspaces/backend/bin/k8s/1.31.0-darwin-arm64" go test ./... -coverprofile cover.out
ok  	github.com/kubeflow/notebooks/workspaces/backend/api	9.029s	coverage: 50.6% of statements
?   	github.com/kubeflow/notebooks/workspaces/backend/internal/config	[no test files]
?   	github.com/kubeflow/notebooks/workspaces/backend/internal/models/health_check	[no test files]
	github.com/kubeflow/notebooks/workspaces/backend/cmd		coverage: 0.0% of statements
	github.com/kubeflow/notebooks/workspaces/backend/internal/models/workspaces		coverage: 0.0% of statements
	github.com/kubeflow/notebooks/workspaces/backend/internal/models/workspacekinds		coverage: 0.0% of statements
	github.com/kubeflow/notebooks/workspaces/backend/internal/repositories		coverage: 0.0% of statements
	github.com/kubeflow/notebooks/workspaces/backend/internal/repositories/workspacekinds		coverage: 0.0% of statements
	github.com/kubeflow/notebooks/workspaces/backend/internal/repositories/workspaces		coverage: 0.0% of statements
	github.com/kubeflow/notebooks/workspaces/backend/internal/repositories/namespaces		coverage: 0.0% of statements
	github.com/kubeflow/notebooks/workspaces/backend/internal/repositories/health_check		coverage: 0.0% of statements
	github.com/kubeflow/notebooks/workspaces/backend/internal/auth		coverage: 0.0% of statements
	github.com/kubeflow/notebooks/workspaces/backend/openapi		coverage: 0.0% of statements
	github.com/kubeflow/notebooks/workspaces/backend/internal/helper		coverage: 0.0% of statements
	github.com/kubeflow/notebooks/workspaces/backend/internal/models/namespaces		coverage: 0.0% of statements
	github.com/kubeflow/notebooks/workspaces/backend/internal/server		coverage: 0.0% of statements

Copy link

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initiative
These image are in good state to be pulled
https://github.com/kubeflow/kubeflow/pkgs/container/kubeflow%2Fnotebook-servers%2Fjupyter-scipy

/lgtm

Copy link

@harshad16: changing LGTM is restricted to collaborators

In response to this:

Great initiative
These image are in good state to be pulled
https://github.com/kubeflow/kubeflow/pkgs/container/kubeflow%2Fnotebook-servers%2Fjupyter-scipy

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thesuperzapper
Copy link
Member

Thanks, @andyatmiami, looks good.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thesuperzapper
Copy link
Member

/ok-to-test

@google-oss-prow google-oss-prow bot merged commit dd4ef1f into kubeflow:notebooks-v2 Jun 26, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Kubeflow Notebooks Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants