Skip to content

feat(ws): Introduce drawer to workspace creation wizard #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: notebooks-v2
Choose a base branch
from

Conversation

thaorell
Copy link

@thaorell thaorell commented May 6, 2025

closes: #249

screencast-localhost_9000-2025_05_06-10_45_22.webm

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested review from ederign and kimwnasptd May 6, 2025 14:46
@thaorell thaorell force-pushed the notebooks-v2-workspace-creation-ui-enhancements branch from 4cc7471 to 9b27b1a Compare May 6, 2025 14:46
@thaorell thaorell changed the title feat(s): Introduce drawer to workspace creation wizard feat(ws): Introduce drawer to workspace creation wizard May 6, 2025
@thaorell thaorell force-pushed the notebooks-v2-workspace-creation-ui-enhancements branch from 9b27b1a to 9fcb9a2 Compare May 6, 2025 14:49
@thaorell
Copy link
Author

thaorell commented May 6, 2025

@jenny-s51 please review

@paulovmr
Copy link

paulovmr commented May 7, 2025

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

2 participants