feat(ws): Introduce drawer to workspace creation wizard #310
Conversation
thaorell
force-pushed
the
notebooks-v2-workspace-creation-ui-enhancements
branch
from
4cc7471 to
9b27b1a
Compare
thaorell
changed the title
thaorell
force-pushed
the
notebooks-v2-workspace-creation-ui-enhancements
branch
from
9b27b1a to
9fcb9a2
Compare
|
@jenny-s51 please review |
|
/ok-to-test |
There was a problem hiding this comment.
Awesome work on this @thaorell ! The functionality of the drawer is looking really solid and this is a great addition.
Can we implement the drawer to utilize the full height of the content area? It's not rendering at full height at the moment.
It should take the full height of the page container, similar to the drawer in the workspaces list view:
...frontend/src/app/pages/Workspaces/Creation/podConfig/WorkspaceCreationPodConfigSelection.tsx
Outdated
Show resolved
Hide resolved
thaorell
force-pushed
the
notebooks-v2-workspace-creation-ui-enhancements
branch
from
c79bcde to
22e02d8
Compare
There was a problem hiding this comment.
Thank you for making these changes @thaorell - nice work. Left a comment below and opened an issue in PF to address a gap with the Wizard component that's causing the issue for which you had to apply the CSS override.
We'll want to remove this override in the future - can we add a comment with the PF issue number to track its resolution?
Otherwise LGTM 🚀
| .pf-v6-c-page__main-section .pf-v6-c-page__main-body { | ||
| height: 100%; | ||
| } | ||
|
|
There was a problem hiding this comment.
Given that we've created our own custom implementation of a "Wizard", for the Workspace Creation, this may be the best we can do right now. We really shouldn't have to apply a CSS override for the Drawer to render at full height though.
I've opened patternfly/patternfly-react#11826 so Patternfly can handle custom component integration in Wizards better, since our use case has some pretty specific instances of components that the Wizard isn't currently built to support.
There was a problem hiding this comment.
Great idea! I'll follow the issue as well. Thank you for opening it!
|
@thaorell could you please rebase this PR to fix the conflicts? |
thaorell
force-pushed
the
notebooks-v2-workspace-creation-ui-enhancements
branch
from
22e02d8 to
c570d62
Compare
Signed-off-by: Charles Thao <[email protected]> fix(ws): Change label titles in Workspace Creation Signed-off-by: Charles Thao <[email protected]> Add custom rules for drawer body to have full length Signed-off-by: Charles Thao <[email protected]>
thaorell
force-pushed
the
notebooks-v2-workspace-creation-ui-enhancements
branch
from
c570d62 to
4f5af83
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
fix(ws): Change label titles in Workspace Creation Add custom rules for drawer body to have full length Signed-off-by: Charles Thao <[email protected]>
fix(ws): Change label titles in Workspace Creation Add custom rules for drawer body to have full length Signed-off-by: Charles Thao <[email protected]> Signed-off-by: CI Bot <[email protected]>
fix(ws): Change label titles in Workspace Creation Add custom rules for drawer body to have full length Signed-off-by: Charles Thao <[email protected]>
fix(ws): Change label titles in Workspace Creation Add custom rules for drawer body to have full length Signed-off-by: Charles Thao <[email protected]> Signed-off-by: CI Bot <[email protected]>
closes: #249
screencast-localhost_9000-2025_05_06-10_45_22.webm