Skip to content

Conversation

@caponetto
Copy link

@caponetto caponetto commented May 7, 2025

Closes #269

In this PR:

  • Enable start:dev with real data and start:dev:mock with mocked data
  • Reorganize mock-related code
  • Refactor FE types according to BE types and adapt the FE code accordingly
  • Reorganize FE types
  • Prepare FE code for create/update/patch
  • Add error boundary component
  • Enable Create Workspace

@jiridanek
Copy link
Member

/ok-to-test

Copy link

@paulovmr paulovmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caponetto LGTM! As we talked, let's wait to merge #303 before this one.

@caponetto caponetto force-pushed the RHOAIENG-24599 branch 3 times, most recently from 04a0d59 to 0c96cc8 Compare May 9, 2025 10:17
caponetto added 12 commits May 12, 2025 09:00
Signed-off-by: Guilherme Caponetto <[email protected]>
Signed-off-by: Guilherme Caponetto <[email protected]>
Signed-off-by: Guilherme Caponetto <[email protected]>
Signed-off-by: Guilherme Caponetto <[email protected]>
Signed-off-by: Guilherme Caponetto <[email protected]>
Signed-off-by: Guilherme Caponetto <[email protected]>
Signed-off-by: Guilherme Caponetto <[email protected]>
Signed-off-by: Guilherme Caponetto <[email protected]>
Signed-off-by: Guilherme Caponetto <[email protected]>
Copy link

@paulovmr paulovmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ederign
Copy link
Member

ederign commented May 13, 2025

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit aa45741 into kubeflow:notebooks-v2 May 13, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Kubeflow Notebooks May 13, 2025
mkoushni pushed a commit to mkoushni/notebooks that referenced this pull request May 28, 2025
…ubeflow#314)

* Enable start:dev with real data and start:dev:mock with mocked data

Signed-off-by: Guilherme Caponetto <[email protected]>

* Reorganize mock-related code

Signed-off-by: Guilherme Caponetto <[email protected]>

* Refactor FE types according to BE types and adapt the FE code accordingly

Signed-off-by: Guilherme Caponetto <[email protected]>

* Reorganize types

Signed-off-by: Guilherme Caponetto <[email protected]>

* Prepare code for create/update/patch

Signed-off-by: Guilherme Caponetto <[email protected]>

* Format files with prettier

Signed-off-by: Guilherme Caponetto <[email protected]>

* Clean up unnecessary eslint comments

Signed-off-by: Guilherme Caponetto <[email protected]>

* Minor adjustments after rebase

Signed-off-by: Guilherme Caponetto <[email protected]>

* Add error boundary

Signed-off-by: Guilherme Caponetto <[email protected]>

* Add EnsureAPIAvailability component

Signed-off-by: Guilherme Caponetto <[email protected]>

* Add instructions for running the UI with a mocked API

Signed-off-by: Guilherme Caponetto <[email protected]>

* Enable create workspace

Signed-off-by: Guilherme Caponetto <[email protected]>

---------

Signed-off-by: Guilherme Caponetto <[email protected]>
Signed-off-by: CI Bot <[email protected]>
mkoushni pushed a commit to mkoushni/notebooks that referenced this pull request Jun 4, 2025
…ubeflow#314)

* Enable start:dev with real data and start:dev:mock with mocked data

Signed-off-by: Guilherme Caponetto <[email protected]>

* Reorganize mock-related code

Signed-off-by: Guilherme Caponetto <[email protected]>

* Refactor FE types according to BE types and adapt the FE code accordingly

Signed-off-by: Guilherme Caponetto <[email protected]>

* Reorganize types

Signed-off-by: Guilherme Caponetto <[email protected]>

* Prepare code for create/update/patch

Signed-off-by: Guilherme Caponetto <[email protected]>

* Format files with prettier

Signed-off-by: Guilherme Caponetto <[email protected]>

* Clean up unnecessary eslint comments

Signed-off-by: Guilherme Caponetto <[email protected]>

* Minor adjustments after rebase

Signed-off-by: Guilherme Caponetto <[email protected]>

* Add error boundary

Signed-off-by: Guilherme Caponetto <[email protected]>

* Add EnsureAPIAvailability component

Signed-off-by: Guilherme Caponetto <[email protected]>

* Add instructions for running the UI with a mocked API

Signed-off-by: Guilherme Caponetto <[email protected]>

* Enable create workspace

Signed-off-by: Guilherme Caponetto <[email protected]>

---------

Signed-off-by: Guilherme Caponetto <[email protected]>
Signed-off-by: CI Bot <[email protected]>
mkoushni pushed a commit to mkoushni/notebooks that referenced this pull request Jun 11, 2025
…ubeflow#314)

* Enable start:dev with real data and start:dev:mock with mocked data

Signed-off-by: Guilherme Caponetto <[email protected]>

* Reorganize mock-related code

Signed-off-by: Guilherme Caponetto <[email protected]>

* Refactor FE types according to BE types and adapt the FE code accordingly

Signed-off-by: Guilherme Caponetto <[email protected]>

* Reorganize types

Signed-off-by: Guilherme Caponetto <[email protected]>

* Prepare code for create/update/patch

Signed-off-by: Guilherme Caponetto <[email protected]>

* Format files with prettier

Signed-off-by: Guilherme Caponetto <[email protected]>

* Clean up unnecessary eslint comments

Signed-off-by: Guilherme Caponetto <[email protected]>

* Minor adjustments after rebase

Signed-off-by: Guilherme Caponetto <[email protected]>

* Add error boundary

Signed-off-by: Guilherme Caponetto <[email protected]>

* Add EnsureAPIAvailability component

Signed-off-by: Guilherme Caponetto <[email protected]>

* Add instructions for running the UI with a mocked API

Signed-off-by: Guilherme Caponetto <[email protected]>

* Enable create workspace

Signed-off-by: Guilherme Caponetto <[email protected]>

---------

Signed-off-by: Guilherme Caponetto <[email protected]>
Signed-off-by: CI Bot <[email protected]>
mkoushni pushed a commit to mkoushni/notebooks that referenced this pull request Jun 11, 2025
…ubeflow#314)

* Enable start:dev with real data and start:dev:mock with mocked data

Signed-off-by: Guilherme Caponetto <[email protected]>

* Reorganize mock-related code

Signed-off-by: Guilherme Caponetto <[email protected]>

* Refactor FE types according to BE types and adapt the FE code accordingly

Signed-off-by: Guilherme Caponetto <[email protected]>

* Reorganize types

Signed-off-by: Guilherme Caponetto <[email protected]>

* Prepare code for create/update/patch

Signed-off-by: Guilherme Caponetto <[email protected]>

* Format files with prettier

Signed-off-by: Guilherme Caponetto <[email protected]>

* Clean up unnecessary eslint comments

Signed-off-by: Guilherme Caponetto <[email protected]>

* Minor adjustments after rebase

Signed-off-by: Guilherme Caponetto <[email protected]>

* Add error boundary

Signed-off-by: Guilherme Caponetto <[email protected]>

* Add EnsureAPIAvailability component

Signed-off-by: Guilherme Caponetto <[email protected]>

* Add instructions for running the UI with a mocked API

Signed-off-by: Guilherme Caponetto <[email protected]>

* Enable create workspace

Signed-off-by: Guilherme Caponetto <[email protected]>

---------

Signed-off-by: Guilherme Caponetto <[email protected]>
Signed-off-by: CI Bot <[email protected]>
andyatmiami pushed a commit to andyatmiami/kubeflow-notebooks that referenced this pull request Jun 13, 2025
…ubeflow#314)

* Enable start:dev with real data and start:dev:mock with mocked data

Signed-off-by: Guilherme Caponetto <[email protected]>

* Reorganize mock-related code

Signed-off-by: Guilherme Caponetto <[email protected]>

* Refactor FE types according to BE types and adapt the FE code accordingly

Signed-off-by: Guilherme Caponetto <[email protected]>

* Reorganize types

Signed-off-by: Guilherme Caponetto <[email protected]>

* Prepare code for create/update/patch

Signed-off-by: Guilherme Caponetto <[email protected]>

* Format files with prettier

Signed-off-by: Guilherme Caponetto <[email protected]>

* Clean up unnecessary eslint comments

Signed-off-by: Guilherme Caponetto <[email protected]>

* Minor adjustments after rebase

Signed-off-by: Guilherme Caponetto <[email protected]>

* Add error boundary

Signed-off-by: Guilherme Caponetto <[email protected]>

* Add EnsureAPIAvailability component

Signed-off-by: Guilherme Caponetto <[email protected]>

* Add instructions for running the UI with a mocked API

Signed-off-by: Guilherme Caponetto <[email protected]>

* Enable create workspace

Signed-off-by: Guilherme Caponetto <[email protected]>

---------

Signed-off-by: Guilherme Caponetto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants