Skip to content

Commit 7578361

Browse files
committed
fix: propagate pipeline version id and tls health check
Signed-off-by: sduvvuri1603 <[email protected]>
1 parent 542637d commit 7578361

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

.github/resources/scripts/ensure-kfp-api.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,13 @@ else
3737
fi
3838

3939
SCHEME="http"
40+
TARGET_HOST="localhost"
4041
declare -a CURL_OPTS=(-sf)
4142

4243
if [[ "${TLS_ENABLED}" == "true" ]]; then
4344
SCHEME="https"
45+
TARGET_HOST="${SERVICE_NAME}.${NAMESPACE}.svc.cluster.local"
46+
CURL_OPTS+=(--resolve "${TARGET_HOST}:${API_PORT}:127.0.0.1")
4447
if [[ -n "${CA_CERT_PATH}" ]]; then
4548
CURL_OPTS+=(--cacert "${CA_CERT_PATH}")
4649
else
@@ -49,7 +52,7 @@ if [[ "${TLS_ENABLED}" == "true" ]]; then
4952
fi
5053

5154
for attempt in {1..30}; do
52-
if curl "${CURL_OPTS[@]}" "${SCHEME}://localhost:${API_PORT}/apis/v2beta1/healthz" >/dev/null; then
55+
if curl "${CURL_OPTS[@]}" "${SCHEME}://${TARGET_HOST}:${API_PORT}/apis/v2beta1/healthz" >/dev/null; then
5356
log "KFP API server is ready."
5457
exit 0
5558
fi

backend/src/apiserver/template/v2_template.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,9 @@ func (t *V2Spec) ScheduledWorkflow(modelJob *model.Job) (*scheduledworkflow.Sche
148148
DefaultWorkspace: t.templateOptions.DefaultWorkspace,
149149
MLPipelineTLSEnabled: t.templateOptions.MLPipelineTLSEnabled,
150150
}
151+
if modelJob.PipelineVersionId != "" {
152+
opts.PipelineVersionID = modelJob.PipelineVersionId
153+
}
151154
obj, err = argocompiler.Compile(job, kubernetesSpec, opts)
152155
}
153156
if err != nil {

0 commit comments

Comments
 (0)