WIP: feat(sdk)Add PodmanRunner #11855
Draft
+469
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
anishasthana
force-pushed
the
add_podman
branch
from
e68a30a to
b611d73
Compare
|
This is definitely not ready for review yet. I'll let you folks know when it is! |
This is almost entirely based on the existing docker runner implementation, with minor differences for podman specifics Signed-off-by: Anish Asthana <[email protected]>
anishasthana
force-pushed
the
add_podman
branch
from
b611d73 to
40b7532
Compare
|
Implementing this in a user-friendly way is blocked on containers/podman-py#544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is almost entirely based on the existing docker runner implementation, with minor differences for podman specifics
Closes #11865