-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(ui): add ESC
shortcut for closing SidePanel. Fixes #11873
#11874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @EnyMan. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🚫 This command cannot be processed. Only organization members or owners can use the commands. |
/ok-to-test |
Approvals successfully granted for pending runs. |
Signed-off-by: EnyMan <[email protected]>
950f1fb
to
bfbc917
Compare
/ok-to-test |
Approvals successfully granted for pending runs. |
I think this needs a retest (at least partial), as the GA failed with:
tested "wgeting" the url and that worked. |
/retest |
Description of your changes:
Add a shortcut for closing SidePanel. Fixes #11873
Checklist: