feat(launcher): Add credential refresh to launcher #12708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdevoto
force-pushed
the
credential-refresh
branch
2 times, most recently
from
c9a059b to
24f0380
Compare
Signed-off-by: Caroline DeVoto <[email protected]> Co-authored-by: droctothorpe <[email protected]>
droctothorpe
force-pushed
the
credential-refresh
branch
from
24f0380 to
95f9b60
Compare
Collaborator
|
Thank you, @cmdevoto! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droctothorpe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 19f64ec
into
kubeflow:master
147 of 148 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Caroline DeVoto [email protected]
Co-authored-by: droctothorpe [email protected]
Description of your changes:
These changes introduce credential refreshing to the launcher so that if the first attempt at
uploadOutputArtifactsfails, credentials will be refreshed prior to retrying artifact upload.Checklist: