Skip to content

Conversation

@Sayan4496
Copy link

Fixes #12720

Removed "localhost" from kfp-api-cert dnsNames list to avoid insecure/non-standard certificate SAN configuration.

@google-oss-prow google-oss-prow bot requested a review from gmfrasca January 29, 2026 14:29
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

Hi @Sayan4496. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

🎉 Welcome to the Kubeflow Pipelines repo! 🎉

Thanks for opening your first PR! We're excited to have you onboard 🚀

Next steps:

Feel free to ask questions in the comments.

@Sayan4496
Copy link
Author

It looks like this issue has already been addressed in #12718.
Closing this PR to avoid duplicate work. Thanks!

@Sayan4496 Sayan4496 closed this Jan 29, 2026
@Sayan4496 Sayan4496 deleted the chore-remove-localhost-from-cert branch January 29, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(manifests): Remove "localhost" from kfp-api-cert

1 participant