Skip to content

Conversation

@alyssacgoins
Copy link
Contributor

@alyssacgoins alyssacgoins commented Jan 29, 2026

Description of your changes:
Add the current date to the cache key used in .github/workflows/image-builds-with-cache.yml. This forces the cache key to change daily, so that old image markers disappear after midnight, syncing cache expiration with single-day artifact retention.This change should fix the CI bug in which image artifacts fail to be located.

This PR is a follow-up to the cache lookups added in #12712.
Resolves #12734

Checklist:

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@alyssacgoins alyssacgoins changed the title Increase retention for image-builds-with-cache artifacts fix(testing) retention for image-builds-with-cache artifacts Jan 29, 2026
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alyssacgoins alyssacgoins marked this pull request as ready for review January 29, 2026 19:49
@google-oss-prow google-oss-prow bot requested a review from nsingla January 29, 2026 19:49
@google-oss-prow google-oss-prow bot merged commit 3e35c4b into kubeflow:master Jan 29, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] CI build-image-with-cache fails to locate image

2 participants