chore(frontend): add engines field to package.json#13038
Open
jsonmp-k8 wants to merge 2 commits intokubeflow:masterfrom
Open
chore(frontend): add engines field to package.json#13038jsonmp-k8 wants to merge 2 commits intokubeflow:masterfrom
jsonmp-k8 wants to merge 2 commits intokubeflow:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/ok-to-test |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Node.js version constraint to the frontend’s package.json to help align local/CI environments with the intended Node version (per the Node 24 upgrade work in #13037).
Changes:
- Add
"engines": { "node": ">=24.0.0" }tofrontend/package.json.
Enforce a minimum Node.js version of 24.0.0 in package.json to prevent version drift and surface mismatches early during npm install rather than at runtime. Signed-off-by: Jaison Paul <paul.jaison@gmail.com>
- Tighten engines range to >=24.0.0 <25.0.0 to prevent unintended major version upgrades - Add .npmrc with engine-strict=true so npm ci/install fails on version mismatch instead of just warning - Un-ignore .npmrc in .gitignore so the project config is tracked Signed-off-by: Jaison Paul <paul.jaison@gmail.com>
jsonmp-k8
force-pushed
the
chore/frontend-engines-field
branch
from
39fc9e2 to
53182e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"engines": { "node": ">=24.0.0 <25.0.0" }tofrontend/package.jsonto constrain to the Node 24 LTS linefrontend/.npmrcwithengine-strict=truesonpm ci/npm installfails (not just warns) on version mismatch.npmrcinfrontend/.gitignoreso the project config is tracked (personal overrides belong in~/.npmrc)npm installrather than at runtimeDepends on #13037 (Node 24 upgrade) being merged first.
Test plan
npm cisucceeds with Node 24npm cifails with Node 22 (engines check enforced via.npmrc)npm cifails with Node 25+ (upper bound constraint)