Skip to content

backend(proposal): adding proposal to extend and unify storage layer#13254

Open
nsingla wants to merge 1 commit intokubeflow:masterfrom
nsingla:support_multi_object_storage_proposal
Open

backend(proposal): adding proposal to extend and unify storage layer#13254
nsingla wants to merge 1 commit intokubeflow:masterfrom
nsingla:support_multi_object_storage_proposal

Conversation

@nsingla
Copy link
Copy Markdown
Contributor

@nsingla nsingla commented Apr 10, 2026

Description of your changes:

Checklist:

Copilot AI review requested due to automatic review settings April 10, 2026 19:28
@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zazulam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

@Amr-Shams Amr-Shams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i read the proposal, admired the idea and i have a genuine question,

go CDK already has a URL-based mux that dispatches by scheme, so why would adding another custom layer to register? while can be done with the custom url by go CDK?

@nsingla
Copy link
Copy Markdown
Contributor Author

nsingla commented Apr 13, 2026

i read the proposal, admired the idea and i have a genuine question,

go CDK already has a URL-based mux that dispatches by scheme, so why would adding another custom layer to register? while can be done with the custom url by go CDK?

That's a good question that I probably should address in the proposal as well, but to answer your question:

The custom registry exists because Go CDK's URL mux is designed for stateless, environment-driven credential resolution, while KFP's credential model is request-scoped and depends on Kubernetes API calls that require injected runtime objects. The URL mux is still used as the fallback for the simpler FromEnv case.
Also, the intent of the change is to make the change with the least possible code change with no regression, and Go CDK provides that layer that is required to support this, but in order to do that, we need to bypass its mux to continue to use our own.

@nsingla nsingla force-pushed the support_multi_object_storage_proposal branch 2 times, most recently from 8960582 to 011b1a9 Compare April 17, 2026 13:56
Signed-off-by: Nelesh Singla <117123879+nsingla@users.noreply.github.com>
@nsingla nsingla force-pushed the support_multi_object_storage_proposal branch from 011b1a9 to f42dada Compare April 17, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants