feat(backend): expose v2beta1 auth and visualization via HTTP gateway. Part of #13283#13284
feat(backend): expose v2beta1 auth and visualization via HTTP gateway. Part of #13283#13284Amr-Shams wants to merge 4 commits intokubeflow:masterfrom
Conversation
Signed-off-by: Amr-Shams <amr.shams2015.as@gmail.com>
Signed-off-by: Amr-Shams <amr.shams2015.as@gmail.com>
Signed-off-by: Amr-Shams <amr.shams2015.as@gmail.com>
Signed-off-by: Amr-Shams <amr.shams2015.as@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Amr-Shams. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Pull request overview
This PR aims to provide v2beta1 parity for Auth and Visualization by registering their v2beta1 handlers/servers so the REST paths are reachable via the gRPC-Gateway, while preserving existing v1beta1 behavior.
Changes:
- Register
v2beta1Auth and Visualization services on both the gRPC server and HTTP gateway. - Split Auth/Visualization implementations into explicit V1 vs V2 server types.
- Expand/adjust unit tests to cover
v1beta1andv2beta1flows for visualization and auth.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| backend/src/apiserver/server/visualization_server.go | Refactors visualization server into V1/V2 variants and centralizes URL/aliveness logic. |
| backend/src/apiserver/server/visualization_server_test.go | Adds V1/V2 test coverage and new helpers for visualization URL + service interaction. |
| backend/src/apiserver/server/auth_server.go | Splits Auth server into V1/V2 types and adds V1 request validation helper. |
| backend/src/apiserver/server/auth_server_test.go | Adds v2beta1 auth tests and updates V1 tests to use the V1 server type. |
| backend/src/apiserver/main.go | Registers V2 Auth/Visualization with gRPC and HTTP gateway; updates V1 registration to use new constructors. |
Description of your changes:
This PR adds
v2beta1parity for Auth and Visualization exposure.AuthServiceandVisualizationServiceforv2beta1on the HTTP gateway (startHTTPProxy), so REST paths are reachable.v1beta1behavior unchanged.Issue: 13283
Validation:
go test -v ./backend/src/apiserver/serverChecklist: