Skip to content

feat(backend): expose v2beta1 auth and visualization via HTTP gateway. Part of #13283#13284

Open
Amr-Shams wants to merge 4 commits intokubeflow:masterfrom
Amr-Shams:feat/v2-auth-visual-gateway
Open

feat(backend): expose v2beta1 auth and visualization via HTTP gateway. Part of #13283#13284
Amr-Shams wants to merge 4 commits intokubeflow:masterfrom
Amr-Shams:feat/v2-auth-visual-gateway

Conversation

@Amr-Shams
Copy link
Copy Markdown

@Amr-Shams Amr-Shams commented Apr 16, 2026

Description of your changes:

This PR adds v2beta1 parity for Auth and Visualization exposure.

  • Registers AuthService and VisualizationService for v2beta1 on the HTTP gateway (startHTTPProxy), so REST paths are reachable.
  • Keeps existing v1beta1 behavior unchanged.

Issue: 13283

Validation:

Signed-off-by: Amr-Shams <amr.shams2015.as@gmail.com>
Signed-off-by: Amr-Shams <amr.shams2015.as@gmail.com>
Signed-off-by: Amr-Shams <amr.shams2015.as@gmail.com>
Signed-off-by: Amr-Shams <amr.shams2015.as@gmail.com>
Copilot AI review requested due to automatic review settings April 16, 2026 12:57
@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mprahl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link
Copy Markdown

Hi @Amr-Shams. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to provide v2beta1 parity for Auth and Visualization by registering their v2beta1 handlers/servers so the REST paths are reachable via the gRPC-Gateway, while preserving existing v1beta1 behavior.

Changes:

  • Register v2beta1 Auth and Visualization services on both the gRPC server and HTTP gateway.
  • Split Auth/Visualization implementations into explicit V1 vs V2 server types.
  • Expand/adjust unit tests to cover v1beta1 and v2beta1 flows for visualization and auth.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
backend/src/apiserver/server/visualization_server.go Refactors visualization server into V1/V2 variants and centralizes URL/aliveness logic.
backend/src/apiserver/server/visualization_server_test.go Adds V1/V2 test coverage and new helpers for visualization URL + service interaction.
backend/src/apiserver/server/auth_server.go Splits Auth server into V1/V2 types and adds V1 request validation helper.
backend/src/apiserver/server/auth_server_test.go Adds v2beta1 auth tests and updates V1 tests to use the V1 server type.
backend/src/apiserver/main.go Registers V2 Auth/Visualization with gRPC and HTTP gateway; updates V1 registration to use new constructors.

Comment thread backend/src/apiserver/server/visualization_server.go
Comment thread backend/src/apiserver/main.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants