Skip to content

chore(hub): add kubeflow hub approver jonburdo#252

Merged
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
jonburdo:kubeflow-hub-approver-jonburdo
Feb 3, 2026
Merged

chore(hub): add kubeflow hub approver jonburdo#252
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
jonburdo:kubeflow-hub-approver-jonburdo

Conversation

@jonburdo
Copy link
Copy Markdown
Member

@jonburdo jonburdo commented Feb 2, 2026

The main kubeflow hub repo added jonburdo to the OWNERS file in this PR: kubeflow/hub#2162

This makes the same change to kubeflow/hub/OWNERS

@google-oss-prow google-oss-prow Bot requested review from fege and szaher February 2, 2026 20:23
@jonburdo
Copy link
Copy Markdown
Member Author

jonburdo commented Feb 2, 2026

/cc @tarilabs

@google-oss-prow google-oss-prow Bot requested a review from tarilabs February 2, 2026 20:23
jonburdo added a commit to jonburdo/model-registry that referenced this pull request Feb 2, 2026
This cleans up the root OWNERS file to follow best-practice and to match
the state of the kubeflow sdk file:
https://github.com/kubeflow/sdk/blob/main/kubeflow/hub/OWNERS

after the following PR is merged:
kubeflow/sdk#252

Specifically this does the following:

- move andreyvelich to emeritus_approvers (no longer active)
  (per this comment: kubeflow/sdk#244 (comment) )
- remove duplicate reviewers entries which are also in approvers:
  - Al-Pragliola
  - pboyd

Also see: kubeflow/sdk#244 (comment)

Following this, these OWNERS files should be kept in sync:
https://github.com/kubeflow/model-registry/blob/main/OWNERS
https://github.com/kubeflow/sdk/blob/main/kubeflow/hub/OWNERS

Signed-off-by: Jon Burdo <jon@jonburdo.com>
Copy link
Copy Markdown
Contributor

@kramaranya kramaranya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congrats, @jonburdo!
/lgtm
/approve

@kramaranya
Copy link
Copy Markdown
Contributor

/retest

@andreyvelich
Copy link
Copy Markdown
Member

@jonburdo Can you rebase your PR to fix CI pls?

The main kubeflow hub repo added jonburdo to the OWNERS file in this PR:
kubeflow/hub#2162

This makes the same change to kubeflow/hub/OWNERS

Signed-off-by: Jon Burdo <jon@jonburdo.com>
@jonburdo jonburdo force-pushed the kubeflow-hub-approver-jonburdo branch from 0908365 to 633edd0 Compare February 3, 2026 02:06
@google-oss-prow google-oss-prow Bot removed the lgtm label Feb 3, 2026
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 21613977937

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.52%

Totals Coverage Status
Change from base Build 21609774904: 0.0%
Covered Lines: 2769
Relevant Lines: 4101

💛 - Coveralls

Copy link
Copy Markdown
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work @jonburdo!
/lgtm
/approve

@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, kramaranya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit 193f043 into kubeflow:main Feb 3, 2026
16 checks passed
@google-oss-prow google-oss-prow Bot added this to the v0.4 milestone Feb 3, 2026
@jonburdo jonburdo deleted the kubeflow-hub-approver-jonburdo branch February 3, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants