chore: add local development with SDK backends guide#261
chore: add local development with SDK backends guide#261Raakshass wants to merge 5 commits intokubeflow:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🎉 Welcome to the Kubeflow SDK! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
4a0f42a to
cf67ce0
Compare
|
@Raakshass Thank you for your interest in contributing. The aim of this issue is to add a guide for customers that would like to use our local and container backends. We would like to show them how to easily switch between available backends, when to use each of them etc. Please re-read the issue description and let me know if you have any questions. |
|
Thanks @Fiona-Waters for the clarification! I misunderstood the scope - I'll revise my PR to focus on the user-facing local and container backends guide instead of contributor dev setup. I'll update it to cover:
Will push the updated content shortly! |
|
@Fiona-Waters I updated the PR content described above. I'm unable to edit the PR title to "docs: add local development with SDK backends guide" - could you please update it? Thanks! |
|
@Fiona-Waters I've updated the PR content as you suggested - it now covers the user-facing backends guide with comparison table, switching examples, and troubleshooting tips. Ready for re-review when you have time! |
Fiona-Waters
left a comment
There was a problem hiding this comment.
Thanks @Raakshass I think this is great. Could we add something around differing container_host for use on mac for example? This could be tricky if the user doesn't know about it.
Fiona-Waters
left a comment
There was a problem hiding this comment.
Thanks @Raakshass
You also need to add to https://github.com/kubeflow/sdk/blob/main/docs/source/index.rst?plain=1 so that the new section will show on the website.
eda32e2 to
29a9833
Compare
|
@Fiona-Waters — addressed both asks: Container host info for Mac — added Container Host Configuration section with OS-specific socket paths table and macOS code example |
Pull Request Test Coverage Report for Build 22003433482Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
- Add Container Host Configuration section with OS-specific socket paths (Linux, macOS, Windows) and macOS Docker Desktop code example - Add backend comparison table (LocalProcess, Container, Kubernetes) - Add code examples for switching between backends - Add common operations and troubleshooting tips - Update grid-item-card description in getting-started/index.rst - Add local-development to main docs/source/index.rst toctree Closes kubeflow#259 Signed-off-by: siddhant jain <siddhantjainofficial26@gmail.com>
29a9833 to
9e32e97
Compare
|
@Fiona-Waters Rebased onto latest
All CI checks passing. Ready for re-review when you get a chance. Thanks! |
Fiona-Waters
left a comment
There was a problem hiding this comment.
Thanks @Raakshass I've left some comments.
| @@ -0,0 +1,239 @@ | |||
| Local Development with SDK Backends | |||
There was a problem hiding this comment.
In the UI, this menu item is quite long. Can we change it to Local Development? I think the description underneath covers the rest. WDYT?
| Local Development with SDK Backends | ||
| ==================================== | ||
|
|
||
| This guide explains how to run Kubeflow training jobs locally using the SDK's |
There was a problem hiding this comment.
| This guide explains how to run Kubeflow training jobs locally using the SDK's | |
| This guide explains how to run Kubeflow TrainJobs locally using the SDK's |
| Overview | ||
| -------- | ||
|
|
||
| The Kubeflow Trainer SDK provides three backends for running training jobs: |
There was a problem hiding this comment.
| The Kubeflow Trainer SDK provides three backends for running training jobs: | |
| The Kubeflow Trainer SDK provides three backends for running TrainJobs: |
| verify the socket path by running ``docker context inspect`` and check | ||
| the ``Host`` value in the output. | ||
|
|
||
| **Choosing Docker vs Podman:** |
There was a problem hiding this comment.
I think this section can be removed.
- Shorten page title to Local Development per reviewer request - Use TrainJobs terminology instead of training jobs - Remove Choosing Docker vs Podman comparison section Signed-off-by: Siddhant Jain <siddhantjainofficial26@gmail.com>
|
@Fiona-Waters Addressed all your review comments: Changes in commit
All changes are in a single new commit on top (no force-push, no history rewrite). Ready for re-review! |
Fiona-Waters
left a comment
There was a problem hiding this comment.
Just a few more small comments. Thank you!
Co-authored-by: Fiona Waters <fiwaters6@gmail.com> Signed-off-by: Siddhant Jain <149181251+Raakshass@users.noreply.github.com>
Co-authored-by: Fiona Waters <fiwaters6@gmail.com> Signed-off-by: Siddhant Jain <149181251+Raakshass@users.noreply.github.com>
Co-authored-by: Fiona Waters <fiwaters6@gmail.com> Signed-off-by: Siddhant Jain <149181251+Raakshass@users.noreply.github.com>
Closes #259
Summary
This PR adds a Local Development with SDK Backends guide to help users understand and switch between available training backends.
Content Covered
Changes Based on Feedback
Revised from contributor dev setup to user-facing backends guide per @Fiona-Waters feedback.
Checklist