Skip to content

fix: Remove manual type validation from SparkClient.connect() #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VHemanth45 wants to merge 1 commit into from
Closed

fix: Remove manual type validation from SparkClient.connect() #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions kubeflow/spark/backends/kubernetes/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,20 +121,6 @@ def _create_session(
options: Optional[list] = None,
) -> SparkConnectInfo:
"""Create a new SparkConnect session (INTERNAL USE ONLY)."""
# Validate input types
if resources_per_executor is not None and not isinstance(resources_per_executor, dict):
raise TypeError(
f"resources_per_executor must be a dict, got {type(resources_per_executor)}"
)
if spark_conf is not None and not isinstance(spark_conf, dict):
raise TypeError(f"spark_conf must be a dict, got {type(spark_conf)}")
if num_executors is not None and not isinstance(num_executors, int):
raise TypeError(f"num_executors must be an int, got {type(num_executors)}")
if driver is not None and not isinstance(driver, Driver):
raise TypeError(f"driver must be a Driver instance, got {type(driver)}")
if executor is not None and not isinstance(executor, Executor):
raise TypeError(f"executor must be an Executor instance, got {type(executor)}")

# Extract Name option if present, or auto-generate
name, filtered_options = self._extract_name_option(options)

Expand Down
Loading