Skip to content

Add support for using cert manager to generate webhook certificates #2373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2025

Conversation

ChenYi015
Copy link
Contributor

@ChenYi015 ChenYi015 commented Dec 24, 2024

Purpose of this PR

Close #1178

Proposed changes:

  • Will use cert manager to generate TLS certificates if certManager.enable is true
  • webhook should sync the certs into local file once the webhook TLS secret has been renewed

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@ChenYi015 ChenYi015 force-pushed the feature/cert-manager branch from 9e8c408 to 5523472 Compare April 8, 2025 16:46
@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Apr 8, 2025
@ChenYi015 ChenYi015 force-pushed the feature/cert-manager branch from 5523472 to 181e4f5 Compare April 9, 2025 03:15
@google-oss-prow google-oss-prow bot added size/XL and removed size/L labels Apr 9, 2025
@ChenYi015 ChenYi015 linked an issue Apr 9, 2025 that may be closed by this pull request
@ChenYi015 ChenYi015 force-pushed the feature/cert-manager branch from 75bef58 to 994638d Compare April 9, 2025 03:48
@ChenYi015 ChenYi015 force-pushed the feature/cert-manager branch from 994638d to 9b3c6e0 Compare April 9, 2025 06:01
@ChenYi015 ChenYi015 marked this pull request as ready for review April 9, 2025 06:02
@google-oss-prow google-oss-prow bot requested a review from mwielgus April 9, 2025 06:02
@ChenYi015
Copy link
Contributor Author

/assign @jacobsalway @vara-bonthu @ImpSy

@ChenYi015 ChenYi015 force-pushed the feature/cert-manager branch from e683133 to 52b1023 Compare May 28, 2025 05:16
Copy link
Contributor

@yuchaoran2011 yuchaoran2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve /lgtm

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuchaoran2011

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 6151064 into kubeflow:master May 28, 2025
15 checks passed
@ChenYi015 ChenYi015 deleted the feature/cert-manager branch May 28, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use CertManager for webhook certificates
5 participants