Skip to content

Conversation

@ChenYi015
Copy link
Member

What this PR does / why we need it:

Add integration test workflow for Helm chart.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #2577

Checklist:

  • Docs included if any changes are user facing

@ChenYi015
Copy link
Member Author

/assign @andreyvelich

@coveralls
Copy link

coveralls commented Apr 11, 2025

Pull Request Test Coverage Report for Build 14689132695

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 62 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 66.59%

Files with Coverage Reduction New Missed Lines %
pkg/runtime/framework/plugins/coscheduling/coscheduling.go 62 0.0%
Totals Coverage Status
Change from base Build 14394472532: 0.1%
Covered Lines: 1738
Relevant Lines: 2610

💛 - Coveralls

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @ChenYi015!
I left a few comments.
/assign @tenzen-y @johnugeorge @saileshd1402 @astefanutti @Electronic-Waste

@google-oss-prow
Copy link

@andreyvelich: GitHub didn't allow me to assign the following users: saileshd1402.

Note that only kubeflow members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

Thank you for this @ChenYi015!
I left a few comments.
/assign @tenzen-y @johnugeorge @saileshd1402 @astefanutti @Electronic-Waste

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andreyvelich. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

env:
BRANCH: ${{ steps.get_branch.outputs.BRANCH }}
run: |
ct install --target-branch $BRANCH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This pull request has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@github-actions github-actions bot closed this Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Helm integration tests to GitHub actions workflow

7 participants