-
Notifications
You must be signed in to change notification settings - Fork 841
feat:add xgboost runtime #2838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat:add xgboost runtime #2838
Conversation
Signed-off-by: Labreo <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Electronic-Waste
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Labreo Thanks for this great feature! We're looking forward to this!
/cc @kubeflow/kubeflow-trainer-team
/ok-to-test
|
@Electronic-Waste: GitHub didn't allow me to request PR reviews from the following users: kubeflow/kubeflow-trainer-team. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Any ideas on how can we test this new runtime? @kubeflow/kubeflow-trainer-team |
Pull Request Test Coverage Report for Build 17851206844Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Thanks for this @Labreo!
We can add E2Es tests to verify it. |
|
Hello @andreyvelich .I mostly used mpi since the other runtimes deepspeed and mlx already use the same policy and it would be the easiest to implement. And it wouldn't require any more custom code in the go controller to run. As for the distributed environment as far as I have learnt the requirements of rabit is fulfilled by MPI.Again this is a draft pr and i am very open to feedback. |
@Labreo Please can you explore how distributed training works in XGBoost these days? Maybe @nqvuong1998 or @terrytangyuan can help us with that ? |
|
MPI should work. There are references here that might be useful https://github.com/kubeflow/xgboost-operator/tree/master/config/samples |
|
Hi @Labreo, did you get a chance to work on this ? |
|
Hi @Labreo , any update for this feature? |
What this PR does / why we need it:
This PR introduces a new
ClusterTrainingRuntimeto support distributed XGBoost training on Kubeflow Trainer. This allows users to easily run distributed XGBoost jobs, expanding the frameworks supported by the project.The implementation follows the existing MPI-based pattern used by the
deepspeedandmlxruntimes. It reuses thempipolicy for a consistent and robust design that requires no changes to the core controller API.This is a work-in-progress to get early feedback on the runtime definition and Dockerfile structure.
What is included in this PR?
xgboost_distributed.yamlClusterTrainingRuntime manifest.Dockerfilefor thexgboost-runtimeimage.requirements.txtwith pinned versions for the XGBoost environment.What is still to come?
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #2598
Checklist: