feat: add e2e tests to Helm CI workflow#3253
feat: add e2e tests to Helm CI workflow#3253Goku2099 wants to merge 8 commits intokubeflow:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR extends the Helm CI workflow to run end-to-end validation by provisioning a Kind cluster and executing the Go E2E test suite, addressing Issue #3230.
Changes:
- Add a Kind cluster setup step to the Helm CI workflow.
- Run Go E2E tests (
make test-e2e) as part of the Helm workflow.
.github/workflows/test-helm.yaml
Outdated
|
|
||
| - name: Setup Kind Cluster | ||
| run: make test-e2e-setup-cluster |
There was a problem hiding this comment.
You need to update this script to deploy Trainer control plane via Helm charts.
Currently, it only uses Kustomize manifests: https://github.com/kubeflow/trainer/blob/master/hack/e2e-setup-cluster.sh#L53
/hold
|
@andreyvelich The Coveralls step is failing with HTTP 530 (error code 1016). This appears to be an external Coveralls issue rather than a CI or coverage configuration problem. The coverage file is generated successfully, but the upload fails. Could you please confirm if we should re-run the job or temporarily ignore this failure? |
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
4982e6f to
d2c9aa2
Compare
|
@andreyvelich can you review this one too. |
This PR extends the existing Helm CI workflow by adding an E2E validation step.
#3230