Skip to content

feat: add e2e tests to Helm CI workflow#3253

Open
Goku2099 wants to merge 8 commits intokubeflow:masterfrom
Goku2099:e2e-test-through-helm
Open

feat: add e2e tests to Helm CI workflow#3253
Goku2099 wants to merge 8 commits intokubeflow:masterfrom
Goku2099:e2e-test-through-helm

Conversation

@Goku2099
Copy link
Contributor

This PR extends the existing Helm CI workflow by adding an E2E validation step.

#3230

Copilot AI review requested due to automatic review settings February 24, 2026 04:25
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jeffwan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the Helm CI workflow to run end-to-end validation by provisioning a Kind cluster and executing the Go E2E test suite, addressing Issue #3230.

Changes:

  • Add a Kind cluster setup step to the Helm CI workflow.
  • Run Go E2E tests (make test-e2e) as part of the Helm workflow.

@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Feb 24, 2026
Comment on lines +25 to +27

- name: Setup Kind Cluster
run: make test-e2e-setup-cluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update this script to deploy Trainer control plane via Helm charts.
Currently, it only uses Kustomize manifests: https://github.com/kubeflow/trainer/blob/master/hack/e2e-setup-cluster.sh#L53
/hold

@Goku2099
Copy link
Contributor Author

@andreyvelich The Coveralls step is failing with HTTP 530 (error code 1016).

This appears to be an external Coveralls issue rather than a CI or coverage configuration problem. The coverage file is generated successfully, but the upload fails.

Could you please confirm if we should re-run the job or temporarily ignore this failure?

Goku2099 and others added 8 commits February 27, 2026 20:43
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
@Goku2099 Goku2099 force-pushed the e2e-test-through-helm branch from 4982e6f to d2c9aa2 Compare February 27, 2026 15:14
@Goku2099
Copy link
Contributor Author

Goku2099 commented Mar 4, 2026

@andreyvelich can you review this one too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants