Skip to content

fix(ci): Bump Python to 3.12 in E2Es#3330

Open
andreyvelich wants to merge 1 commit intokubeflow:masterfrom
andreyvelich:fix-e2e
Open

fix(ci): Bump Python to 3.12 in E2Es#3330
andreyvelich wants to merge 1 commit intokubeflow:masterfrom
andreyvelich:fix-e2e

Conversation

@andreyvelich
Copy link
Member

We should update Python to 3.12 since PyTorch 2.10 uses it.
/cc @kubeflow/kubeflow-trainer-team @akshaychitneni @robert-bell

Copilot AI review requested due to automatic review settings March 13, 2026 15:58
@google-oss-prow
Copy link

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: kubeflow/kubeflow-trainer-team, robert-bell.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

We should update Python to 3.12 since PyTorch 2.10 uses it.
/cc @kubeflow/kubeflow-trainer-team @akshaychitneni @robert-bell

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andreyvelich. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s CI and contributor guidance to run tests/E2Es on Python 3.12, aligning the workflows with the desired Python runtime for the project’s notebook-based E2E coverage.

Changes:

  • Bump Python version to 3.12 in the Python unit/integration CI workflow.
  • Bump Python version to 3.12 in CPU and GPU E2E GitHub Actions workflows.
  • Update CONTRIBUTING requirements to state Python 3.12+.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
CONTRIBUTING.md Updates documented local dev requirements to Python 3.12+.
.github/workflows/test-python.yaml Runs Python unit/integration CI on Python 3.12.
.github/workflows/test-e2e.yaml Runs E2E workflow setup with Python 3.12.
.github/workflows/test-e2e-gpu.yaml Runs GPU E2E workflow setup with Python 3.12.

- [Lima](https://github.com/lima-vm/lima?tab=readme-ov-file#adopters) (an alternative to DockerDesktop) (0.21.0 or later)
- [Colima](https://github.com/abiosoft/colima) (Lima specifically for MacOS) (0.6.8 or later)
- [Python](https://www.python.org/) (3.11 or later)
- [Python](https://www.python.org/) (3.12 or later)
Comment on lines 22 to 25
matrix:
# Python version to run unit and integration tests.
python-version: ["3.11"]
python-version: ["3.12"]

@robert-bell
Copy link
Contributor

Hey @andreyvelich I dug into the failing local-container-mnist.ipynb notebook e2e test on #3227 and it looks like python in the pytorch 2.10 image is now enforcing PEP 668, so pip install fails if we're not running in a venv, which is causing custom train jobs created by the sdk to fail. I think that's the root cause of that test failing, though I don't understand why it didn't fail in the 2.10 upgrade PR.

I think we should be safe to get the sdk to just disable the PEP 668 check if we're running running in a container. I'll open a PR.

@andreyvelich
Copy link
Member Author

Yes, let's update it please.
cc @Fiona-Waters @kubeflow/kubeflow-sdk-team

@robert-bell
Copy link
Contributor

robert-bell commented Mar 13, 2026

I've opened kubeflow/sdk#384 and I've checked that the failing local-container-mnist.ipynb test locally and it's passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants