fix(ci): Bump Python to 3.12 in E2Es#3330
fix(ci): Bump Python to 3.12 in E2Es#3330andreyvelich wants to merge 1 commit intokubeflow:masterfrom
Conversation
|
@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: kubeflow/kubeflow-trainer-team, robert-bell. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
Updates the repository’s CI and contributor guidance to run tests/E2Es on Python 3.12, aligning the workflows with the desired Python runtime for the project’s notebook-based E2E coverage.
Changes:
- Bump Python version to 3.12 in the Python unit/integration CI workflow.
- Bump Python version to 3.12 in CPU and GPU E2E GitHub Actions workflows.
- Update CONTRIBUTING requirements to state Python 3.12+.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CONTRIBUTING.md | Updates documented local dev requirements to Python 3.12+. |
| .github/workflows/test-python.yaml | Runs Python unit/integration CI on Python 3.12. |
| .github/workflows/test-e2e.yaml | Runs E2E workflow setup with Python 3.12. |
| .github/workflows/test-e2e-gpu.yaml | Runs GPU E2E workflow setup with Python 3.12. |
| - [Lima](https://github.com/lima-vm/lima?tab=readme-ov-file#adopters) (an alternative to DockerDesktop) (0.21.0 or later) | ||
| - [Colima](https://github.com/abiosoft/colima) (Lima specifically for MacOS) (0.6.8 or later) | ||
| - [Python](https://www.python.org/) (3.11 or later) | ||
| - [Python](https://www.python.org/) (3.12 or later) |
| matrix: | ||
| # Python version to run unit and integration tests. | ||
| python-version: ["3.11"] | ||
| python-version: ["3.12"] | ||
|
|
|
Hey @andreyvelich I dug into the failing local-container-mnist.ipynb notebook e2e test on #3227 and it looks like python in the pytorch 2.10 image is now enforcing PEP 668, so I think we should be safe to get the sdk to just disable the PEP 668 check if we're running running in a container. I'll open a PR. |
|
Yes, let's update it please. |
|
I've opened kubeflow/sdk#384 and I've checked that the failing local-container-mnist.ipynb test locally and it's passing. |
We should update Python to 3.12 since PyTorch 2.10 uses it.
/cc @kubeflow/kubeflow-trainer-team @akshaychitneni @robert-bell