Skip to content

fix(operator): apply Configuration.ClientConnection QPS/Burst to the manager rest.Config #3446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SAY-5 wants to merge 1 commit into from
+16 −1
Closed

fix(operator): apply Configuration.ClientConnection QPS/Burst to the manager rest.Config #3446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion cmd/trainer-controller-manager/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,22 @@ func main() {
}

setupLog.Info("Creating manager")
mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), options)
restCfg := ctrl.GetConfigOrDie()
// Apply the Configuration.ClientConnection QPS/Burst to the
// manager's rest.Config. Without this, the documented defaults
// (QPS=50, Burst=100) from the Configuration API were validated
// and defaulted but never wired through, so the manager ran with
// the client-go defaults (QPS=5, Burst=10). The status server's
// createClient already uses this pattern (#3431).
if cfg.ClientConnection != nil {
if cfg.ClientConnection.QPS != nil {
restCfg.QPS = *cfg.ClientConnection.QPS
}
if cfg.ClientConnection.Burst != nil {
restCfg.Burst = int(*cfg.ClientConnection.Burst)
}
Comment on lines +122 to +135
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description mentions copying the config (like the status server does), but this code mutates the *rest.Config returned by ctrl.GetConfigOrDie() in place; either update the description or switch to rest.CopyConfig(...) before overriding QPS/Burst for consistency.

Copilot uses AI. Check for mistakes.
}
mgr, err := ctrl.NewManager(restCfg, options)
if err != nil {
setupLog.Error(err, "unable to start manager")
os.Exit(1)
Expand Down
Loading