fix(manifests): Use released version for JobSet and LWS images#3452
Conversation
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the third-party Kustomize manifests for JobSet and LeaderWorkerSet (LWS) to rewrite controller images from the k8s-staging-images registry to the officially released registry.k8s.io images, aligning behavior with how releases are expected to be consumed.
Changes:
- Add Kustomize
imagestransforms for JobSet to map staging image ->registry.k8s.io/jobset/jobset:v0.11.0. - Add Kustomize
imagestransforms for LWS to map staging image ->registry.k8s.io/lws/lws:v0.8.0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| manifests/third-party/leaderworkerset/kustomization.yaml | Adds an image rewrite to use the released LWS image from registry.k8s.io at v0.8.0. |
| manifests/third-party/jobset/kustomization.yaml | Adds an image rewrite to use the released JobSet image from registry.k8s.io at v0.11.0. |
tenzen-y
left a comment
tenzen-y
left a comment
There was a problem hiding this comment.
Thank you, staging image will be removed after 30 days.
So, I would highly recommend embedding the registry.k8s.io in JobSet and LWS release.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-2.2 |
|
@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-2.2 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@tenzen-y: new pull request created: #3453 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…low#3452) Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
It looks like JobSet and LWS kustomize manifests use staging images in their releases:
Ref: https://github.com/kubernetes-sigs/jobset/releases/tag/v0.11.1
We should use the officially released image, like we do in Helm charts.
cc @kubeflow/kubeflow-trainer-team @akshaychitneni @robert-bell @kannon92