fix(controller): add finish logs for early return paths in gc functions

oilbeater · claude · oilbeater · commit 586c1447cb85 · 2026-03-27T02:25:48.000Z
Address review feedback: gcAddressSet and gcSecurityGroup had early
return paths (when nothing to gc) that were missing finish logs.

Signed-off-by: Mengxin Liu &lt;liumengxinfly@gmail.com&gt;
Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
Signed-off-by: Mengxin Liu &lt;liumengxinfly@gmail.com&gt;
diff --git a/pkg/controller/gc.go b/pkg/controller/gc.go
@@ -808,6 +808,7 @@ func (c *Controller) gcAddressSet() error {
 		}
 	}
 	if len(asList) == 0 {
+		klog.Infof("finish to gc address set")
 		return nil
 	}
 
@@ -855,6 +856,7 @@ func (c *Controller) gcSecurityGroup() error {
 		}
 	}
 	if len(needToDelPgs) == 0 {
+		klog.Infof("finish to gc security group residual port groups")
 		return nil
 	}
 	if err = c.OVNNbClient.DeletePortGroup(needToDelPgs...); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -808,6 +808,7 @@ func (c *Controller) gcAddressSet() error {`
`808`	`808`	`}`
`809`	`809`	`}`
`810`	`810`	`if len(asList) == 0 {`
	`811`	`+ klog.Infof("finish to gc address set")`
`811`	`812`	`return nil`
`812`	`813`	`}`
`813`	`814`
`@@ -855,6 +856,7 @@ func (c *Controller) gcSecurityGroup() error {`
`855`	`856`	`}`
`856`	`857`	`}`
`857`	`858`	`if len(needToDelPgs) == 0 {`
	`859`	`+ klog.Infof("finish to gc security group residual port groups")`
`858`	`860`	`return nil`
`859`	`861`	`}`
`860`	`862`	`if err = c.OVNNbClient.DeletePortGroup(needToDelPgs...); err != nil {`